D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY The KPixmapSequence constructor needs the full path of the icon, so the current code doesn't work and generates a "Invalid pixmap specified

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7996 To: elvisangelaccio, #okular Cc: #okular, aacid

Quick question on packages for Ubuntu

2017-09-26 Thread Antonello Lobianco
Quick question on packages for Ubuntu Hello, just a quick question. I'm using Ubuntu 16.04 and installed okular from official pkg sources. I have installed pkg okular 4:15.12.3-0ubuntu1 (that seems to be the latest version). Okular reports me okular version 0.24.2 and kde 4.14.16 On okular downlo

D7996: Properly create KPixmapSequence

2017-09-26 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different. every single instanc

Re: Quick question on packages for Ubuntu

2017-09-26 Thread Albert Astals Cid
El dimarts, 26 de setembre de 2017, a les 10:47:56 CEST, Antonello Lobianco va escriure: > Quick question on packages for Ubuntu > Hello, > just a quick question. I'm using Ubuntu 16.04 and installed okular from > official pkg sources. > I have installed pkg okular 4:15.12.3-0ubuntu1 (that seems

Re: Review Request 129893: Implement continuous search

2017-09-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Sept. 26, 2017, 8:42 p.m.) Review request for Okular, KDE Usabil

[okular] [Bug 385015] Okular does not show XMP metadata for PDFs

2017-09-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=385015 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

Re: Review Request 129893: Implement continuous search

2017-09-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Sept. 26, 2017, 9:28 p.m.) Status -- This change has been m

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D7996#149273, @aacid wrote: > Whoever decided to change from iconName to fullpath deserves some punishment for having a class constructor that has exactly signature but behaves totally different. > > every single instanc

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D7996#149307, @elvisangelaccio wrote: > The weird thing is that I can't find the change with git blame. Shouldn't we just restore the old implementation? Ah no, we can't since KIconLoader is tier3... REPOSITORY R22

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R223:1364d0e97b22: Properly create KPixmapSequence (authored by elvisangelaccio). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7996?vs=19947&id=19958 REVISION DETAIL

Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-09-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130057/#review103741 --- Do you think you could do an autotest using formSamples.pdf