sander added a comment.
From merely looking at the patches, I like this one better than Albert's. In
Albert's patch, the fact that you have to set m_areWeReloading at every exit of
the method slotDoFileDirty does feel like breakage waiting to happen.
On the other hand, Albert's objectio
> On Aug. 24, 2017, 8:45 p.m., Albert Astals Cid wrote:
> > Arthur is useless, I don't see why we should we expose a much worse
> > experience to the user.
>
> Oliver Sander wrote:
> For developing/debugging. Remember that I claimed that Arthur can in
> principle help with some of Okular'
rkflx updated this revision to Diff 18960.
rkflx edited the summary of this revision.
rkflx added a comment.
Thanks Oliver, I like compromises. You inspired me to try another way: Out
with the `unique_lock`, in with the `unique_ptr`. This way no
custom RAII wrapper is needed.
OTOH, I'm n
https://bugs.kde.org/show_bug.cgi?id=288042
francisco navarro morales changed:
What|Removed |Added
CC||navarromorales...@gmail.com
--- Com
sander added a comment.
To be honest, I liked your first patch better. Granted, that definition of
reloadLock is elegant, but you need quite a bit of C++ experience to see its
beauty. People without that will be scared.
But it is really Albert who decides.
REPOSITORY
R223 Okular
RE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---
(Updated Aug. 30, 2017, 2:47 p.m.)
Review request for Okular, KDE Usabili
https://bugs.kde.org/show_bug.cgi?id=288042
Gilbert Assaf changed:
What|Removed |Added
CC||gas...@gmx.de
--- Comment #4 from Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=384185
Bug ID: 384185
Summary: Markdown backend does not reload automatically if the
file has changed
Product: okular
Version: 1.3.70
Platform: Other
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=384185
Albert Astals Cid changed:
What|Removed |Added
Severity|wishlist|normal
CC|
https://bugs.kde.org/show_bug.cgi?id=384185
--- Comment #2 from Oliver Sander ---
Can you reproduce it?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=315552
--- Comment #17 from Christoph Feck ---
Bug 151614?
--
You are receiving this mail because:
You are the assignee for the bug.
heikobecker added a comment.
Ping?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7241
To: heikobecker, #okular, mart
Cc: aacid
https://bugs.kde.org/show_bug.cgi?id=315552
--- Comment #18 from Albert Astals Cid ---
(In reply to Christoph Feck from comment #17)
> Bug 151614?
No, this bug is about "Ctrl+S" actually working like in a normal program. Which
we don't have yet.
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=384147
--- Comment #5 from Albert Astals Cid ---
Well, you'll need to be a bit more precise, so please
* Attach the file you're using
* Say exactly what you're doing and what you're expecting.
--
You are receiving this mail because:
You are the assignee for
https://bugs.kde.org/show_bug.cgi?id=380154
--- Comment #3 from yousifjka...@yahoo.com ---
Hi.
It is a remainder about this issue.
Dear due you will accept to add this feature or not ?
If yes, please allow me to add something I forgot in 1st post of this thread:
regarding rulers they should b
https://bugs.kde.org/show_bug.cgi?id=384142
Albert Astals Cid changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/oku
https://bugs.kde.org/show_bug.cgi?id=384185
--- Comment #3 from Albert Astals Cid ---
Yes works for me.
HAvne't you destroyed this feature locally while testing patches D7595/D7495 ?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=384142
--- Comment #4 from Dave Gilbert ---
Not tested, but Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
aacid abandoned this revision.
aacid added a comment.
Got in as
https://commits.kde.org/okular/a6aea956081e8faac2484ab2283a5ab50f9e0bbe
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7495
To: aacid
Cc: rkflx, #okular, aacid
aacid added a comment.
Please abandon this revision, i commited
https://commits.kde.org/okular/a6aea956081e8faac2484ab2283a5ab50f9e0bbe
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7595
To: rkflx, #okular
Cc: sander, aacid
rkflx abandoned this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7595
To: rkflx, #okular
Cc: sander, aacid
21 matches
Mail list logo
