[okular] [Bug 384127] New: Social sharing of annotations

2017-08-29 Thread Brylie Christopher Oxley
https://bugs.kde.org/show_bug.cgi?id=384127 Bug ID: 384127 Summary: Social sharing of annotations Product: okular Version: unspecified Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: wish

[okular] [Bug 384142] New: okular: seg at exit (For multiple input files)

2017-08-29 Thread Dave Gilbert
https://bugs.kde.org/show_bug.cgi?id=384142 Bug ID: 384142 Summary: okular: seg at exit (For multiple input files) Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severit

[okular] [Bug 384143] New: HiPDI: freehand line in presentation mode is blocky

2017-08-29 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384143 Bug ID: 384143 Summary: HiPDI: freehand line in presentation mode is blocky Product: okular Version: 1.3.70 Platform: Other OS: Linux Status: UNCONFIRMED Severit

D6268: HiDPI Support for Okular

2017-08-29 Thread Oliver Sander
sander added a comment. The problem with drawing in presentation mode is now a bug tracker issue: https://bugs.kde.org/show_bug.cgi?id=384143 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6268 To: hetzenecker, davidedmundson, aacid Cc: ngraham, rkflx, sander, a

[okular] [Bug 384147] New: Hovering over annotations no longer shows contents in tooltip

2017-08-29 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=384147 Bug ID: 384147 Summary: Hovering over annotations no longer shows contents in tooltip Product: okular Version: unspecified Platform: Other OS: Linux St

[okular] [Bug 384147] Hovering over annotations no longer shows contents in tooltip

2017-08-29 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384147 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1 from

[okular] [Bug 384147] Hovering over annotations no longer shows contents in tooltip

2017-08-29 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=384147 --- Comment #2 from Michael D --- Well, that is strange. I'm using KDE Neon User Edition. When I hover over an annotation using the browse tool, the cursor changes from a hand to an arrow. If I recall correctly, it never used to do that. Good to know t

Re: Review Request 130235: Allow to select Splash or Arthur render backends

2017-08-29 Thread Albert Astals Cid
> On ago. 24, 2017, 8:45 p.m., Albert Astals Cid wrote: > > Arthur is useless, I don't see why we should we expose a much worse > > experience to the user. > > Oliver Sander wrote: > For developing/debugging. Remember that I claimed that Arthur can in > principle help with some of Okular'

[okular] [Bug 384147] Hovering over annotations no longer shows contents in tooltip

2017-08-29 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384147 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Resolution|---

D7595: Skip reload when another reload is already in progress

2017-08-29 Thread Albert Astals Cid
aacid added a comment. I don't suggest you write anything, there's aleady code that works in my patch and it's really much easier to understand what it does than this one. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7595 To: rkflx, #okular Cc: aacid

D7495: Do not start reloading again if we're reloading

2017-08-29 Thread Albert Astals Cid
aacid added a comment. I shouldn't have really posted this for review, that's why i get for trying to get people to review my code 😄 Yes, the early return is a bit of a problem. But the slotDoFileDirty function has been majorly unchanged for years, and if someone breaks it, well it'll b

D7594: Update to synctex 1.19

2017-08-29 Thread Albert Astals Cid
aacid added a comment. How does this relate to https://bugs.kde.org/show_bug.cgi?id=382011 ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7594 To: rkflx, #okular, sander Cc: aacid

Re: Review Request 129893: Implement continuous search

2017-08-29 Thread Albert Astals Cid
> On feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote: > > i'm not sure i agree with this change, but this doesn't seem the proper way > > to do it, if we're going to continue searching anyways, don't send a > > Okular::Document::EndOfDocumentReached, just continue searching. > > Elvis Angela

[okular] [Bug 384142] okular: seg at exit (For multiple input files)

2017-08-29 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384142 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|---

[okular] [Bug 384142] okular: seg at exit (For multiple input files)

2017-08-29 Thread Dave Gilbert
https://bugs.kde.org/show_bug.cgi?id=384142 --- Comment #2 from Dave Gilbert --- (In reply to Albert Astals Cid from comment #1) > Which Qt are you using? [dg@major ~]$ rpm -qf /lib64/libQt5Core.so.5 qt5-qtbase-5.7.1-19.fc26.x86_64 [dg@major ~]$ ldd /usr/bin/okular|grep -i qt libQt5Netw

[okular] [Bug 384147] Hovering over annotations no longer shows contents in tooltip

2017-08-29 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=384147 --- Comment #4 from Michael D --- Again, I can't say for certain, but I'm pretty sure it was with Neon. I've been using it for some time now. -- You are receiving this mail because: You are the assignee for the bug.

D7594: Update to synctex 1.19

2017-08-29 Thread Henrik Fehlauer
rkflx added a comment. Only used bugzilla's quicksearch which omits NEEDSINFO bugs, so I missed this (sorry). There doesn't seem do be any new information though. I'll add a link to this review. When implementing the patch, I had to decide between the version in the texlive svn and seve

[okular] [Bug 382011] SyncTeX 2017 upgrade

2017-08-29 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=382011 Henrik Fehlauer changed: What|Removed |Added CC||rk...@lab12.net --- Comment #2 from Henrik Fe

D7595: Skip reload when another reload is already in progress

2017-08-29 Thread Henrik Fehlauer
rkflx added a comment. I guess someone else should judge which is easier to read considering the full picture (I got confused by your `areWeReloading` naming, actually). I admit someone not familiar with `std::mutex` semantics would need to read the comment, but understanding a custom RAII w

D7495: Do not start reloading again if we're reloading

2017-08-29 Thread Henrik Fehlauer
rkflx added a comment. Yay for reviews finding problems before users do \o/ > majorly unchanged for years, and if someone breaks it, well it'll break and we'll fix it. If we can choose between a good and an improved solution, I'd say we should always pick the latter. Maybe I should

D7594: Update to synctex 1.19

2017-08-29 Thread Henrik Fehlauer
rkflx added a reviewer: Kile. rkflx added a subscriber: mludwig. rkflx added a comment. @mludwig As Kile is also providing synctex functionality, maybe you are interested in looking at this patch, too. In my rather simple tests Kile worked fine, but you might be more familiar how it is suppos