D6268: HiDPI Support for Okular

2017-06-19 Thread Lukas Hetzenecker
hetzenecker created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY HiDPI Support: This is my initial draft that enables HiDPI throught the application Every pixmap is multiplied by the devicePixelRatioF QPai

D6268: HiDPI Support for Okular

2017-06-19 Thread David Edmundson
davidedmundson added a comment. "Test plan" simply needs to be a list of things you've tried doing so the maintainers can point out if there's any parts you've not thought about. So saying if you tested annotations and what types of files you opened, checked with zoom = 100%..that sort

D6268: HiDPI Support for Okular

2017-06-19 Thread Anthony Fieroni
anthonyfieroni added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6268 To: hetzenecker, davidedmundson, aacid Cc: #okular, aacid

D6268: HiDPI Support for Okular

2017-06-19 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > pageview.cpp:5324 > { > -PageViewItem currentPageItem = NULL; > +const PageViewItem *currentPageItem; > QSize viewportSize = viewport()->size(); This introduce a regression, since pointer can stay uninitialized or nullptr, ca

D6268: HiDPI Support for Okular

2017-06-19 Thread Oliver Sander
sander added a comment. For me the patch didn't quite apply to the latest okular git master. Easy to fix, but still. The problem was the cosmetic changes in shell/main.cpp. After brief testing, the patch appears to do what it is supposed to do in normal page view mode. In presentation

[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)

2017-06-19 Thread Sergio
https://bugs.kde.org/show_bug.cgi?id=367959 --- Comment #5 from Sergio --- Still seen in kubuntu 17.04 with the KDE PPA, that is Okular 1.0.3 Framework 5.35 QT 5.7.1 Poppler 0.48.0 Please, mark as confirmed -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 381405] New: Link to different document does not launch a new instance of Okular, but replaces current open document

2017-06-19 Thread Martin Drozdik
https://bugs.kde.org/show_bug.cgi?id=381405 Bug ID: 381405 Summary: Link to different document does not launch a new instance of Okular, but replaces current open document Product: okular Version: 0.24.0 Platform: Ubuntu Pa

D6185: Okular empty "Tools" context menu

2017-06-19 Thread Emirald Mateli
emateli changed the visibility from "Public (No Login Required)" to "All Users". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6185 To: emateli, #okular Cc: aacid