Re: PDFium plugin

2017-01-21 Thread Gilbert Assaf
I decided to create an pdfium_generator branch, as Albert suggested. I guess the main focus from the pdfium guys is chromium support. But they have at least some pending issues in their bug tracker, which might change things in the future.  And it will take some time anyway to have a fully working

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

2017-01-21 Thread Marduk Bolanos
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129557/ --- (Updated Jan. 21, 2017, 9:52 p.m.) Review request for Okular and Oliver S

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

2017-01-21 Thread Marduk Bolanos
> On Jan. 8, 2017, 4:32 p.m., Albert Astals Cid wrote: > > This is starting to look acceptable. > > > > Could you please add an autotest that fails without this code and works > > with it? > > Marduk Bolanos wrote: > I looked at `SearchTest::testHyphenAtEndOfLineWithoutYOverlap()` for > i