Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-04 Thread Oliver Sander
> On Oct. 2, 2016, 12:33 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > maybe try with installEventFilter(qApp) in the presentation widget, > > override eventFilter() and check for the tablet events in > > PresentationWidget and call setCursor(Qt::BlankCursor) and unsetCursor(). > > > > yo

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-04 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128858/ --- (Updated Oct. 4, 2016, 2:19 p.m.) Review request for Okular. Changes --

[okular] [Bug 368588] Okular preview of certain PDF documents shows empty pages with Okular logo only

2016-10-04 Thread Burkhard Lueck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368588 --- Comment #6 from Burkhard Lueck --- GPL Ghostscript 9.18 (2015-10-05) libspectre1 0.2.7-3ubuntu2 -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-04 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128858/ --- (Updated Oct. 4, 2016, 8:13 p.m.) Review request for Okular. Changes --

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-04 Thread Oliver Sander
> On Oct. 2, 2016, 12:33 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > maybe try with installEventFilter(qApp) in the presentation widget, > > override eventFilter() and check for the tablet events in > > PresentationWidget and call setCursor(Qt::BlankCursor) and unsetCursor(). > > > > yo

Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-04 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129099/ --- Review request for Okular. Repository: okular Description --- Beca

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129099/#review99787 --- I honestly don't see the benefit You changed a delete by a r

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-04 Thread Oliver Sander
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? I see three benefits: a) I can see by looking at the declaration of m_drawingEngine that

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128858/#review99790 --- > I had to add code to the mouseMoveEvent class, to make the