Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-02-15 Thread Albert Astals Cid
> On Feb. 11, 2016, 9:41 p.m., Armin K. wrote: > > I didn't notice this review request and did porting on my own. My patch > > takes into account some things your doesn't at the moment. Can you port the > > version checks and possibly other changes from my RR to your patch, so I > > can close

[Okular-devel] [okular] [Bug 359223] [framework] okular cannot open files with spaces in path or name (both from terminal and from dolphin)

2016-02-15 Thread Albert Astals Cid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=359223 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #5 from Albert As

Re: [Okular-devel] Review Request 127036: Fix for CUPS printing in Okular 1.0.0

2016-02-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127036/#review92421 --- Ship it! Ship It! - Albert Astals Cid On Feb. 11, 2016,

Re: [Okular-devel] Review Request 127036: Fix for CUPS printing in Okular 1.0.0

2016-02-15 Thread Krzysztof Pyrkosz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127036/ --- (Updated Feb. 16, 2016, 1:27 a.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 125020: okular: Add zip/x-rar mimetype to .desktop files

2016-02-15 Thread Albert Astals Cid
> On Sept. 16, 2015, 8:59 p.m., Albert Astals Cid wrote: > > Actually, if you just leave the libokularGenerator_comicbook.desktop change > > this should be ok, tells okular this plugin may know how to open rar files, > > so if you use the file dialog or the command line it should work, but it

[Okular-devel] [okular] [Bug 332372] Edit and save (PDF) Document Information

2016-02-15 Thread Sylvain via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=332372 Sylvain changed: What|Removed |Added CC||ago.sylv...@gmail.com --- Comment #1 from Sylvain --

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

2016-02-15 Thread Albert Astals Cid
> On Feb. 11, 2016, 10:27 p.m., Miklós Máté wrote: > > ui/toc.cpp, line 44 > > > > > > The model has to know about the treeview, see line 209. This also makes > > sure that the model is deleted when the view is d

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-15 Thread Albert Astals Cid
> On Feb. 9, 2016, 11:23 p.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) > > Albert Astals Cid wrote: > that won't fix http:/

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-15 Thread Aleix Pol Gonzalez
> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote: > > The new dialog "file type" looks fugly and tehre's no "all file types" > > anymore. > > Aleix Pol Gonzalez wrote: > https://git.reviewboard.kde.org/r/127024/ > > :) > > Albert Astals Cid wrote: > that won't fix http: