Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-11 Thread Tobias Koenig
> On Aug. 10, 2015, 9:34 p.m., Albert Astals Cid wrote: > > core/annotations.cpp, line 2968 > > > > > > This and ::store are doing virtually nothing? Well, that is the same code the other annotation classes hav

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-11 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/ --- (Updated Aug. 11, 2015, 9:51 a.m.) Review request for Okular, Albert Asta

[Okular-devel] [okular] [Bug 342548] Okular hang up while printing pdf with state "rendering completed"

2015-08-11 Thread David Young
https://bugs.kde.org/show_bug.cgi?id=342548 David Young changed: What|Removed |Added CC||dove.yo...@gmail.com --- Comment #9 from David Yo

Re: [Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

2015-08-11 Thread Tobias Koenig
> On Aug. 10, 2015, 9:23 p.m., Albert Astals Cid wrote: > > What's the difference between this and > > https://git.reviewboard.kde.org/r/124614/ ? Laurent's patch doesn't apply cleanly to framework HEAD anymore... but Laurent is on vacation, so I had to push a new patch (since I'm not allowed

Re: [Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

2015-08-11 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124687/ --- (Updated Aug. 11, 2015, 12:30 p.m.) Review request for Okular, Albert Ast

Re: [Okular-devel] Review Request 124689: Implement eraser tool for presentation view

2015-08-11 Thread Tobias Koenig
> On Aug. 10, 2015, 9:21 p.m., Albert Astals Cid wrote: > > Does this really depend on 124687 ? Yes, it depends on https://git.reviewboard.kde.org/r/124687/ - Tobias --- This is an automatically generated e-mail. To reply, visit: https:

Re: [Okular-devel] Review Request 124689: Implement eraser tool for presentation view

2015-08-11 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124689/ --- (Updated Aug. 11, 2015, 12:52 p.m.) Review request for Okular, Albert Ast

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-11 Thread JakeLinder
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #10 from jakelin...@mail.com --- Just about there, I'll let it sleep tonight and have a fresh look again tomorrow to spot any brain-slippage, then i'll up it to RB. I'll add the tests once we're agreed the interaction is ok. Before upping f

[Okular-devel] [okular] [Bug 342548] Okular hang up while printing pdf with state "rendering completed"

2015-08-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=342548 --- Comment #10 from Albert Astals Cid --- Since your bug is not this bug as you very well said, why are you commenting in this bug instead of opening a new one? -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [Okular-devel] Review Request 124614: Implement "allow quick selection of several colors for drawing in presentation mode" bug 345269

2015-08-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124614/ --- (Updated ago. 11, 2015, 10:52 p.m.) Status -- This change has been d

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #11 from Albert Astals Cid --- - What branch should I rebase against? master - Is there a project-mandated `astyle` incantation (or somth) for code formatting? No, just follow the style of the file -- You are receiving this mail because: