Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-02 Thread Saheb Preet Singh
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 2, 2014, 1:58 p.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-02 Thread Saheb Preet Singh
> On Dec. 31, 2013, 2:53 p.m., Albert Astals Cid wrote: > > any reason you've implemented the custom key event handler instead of > > implementing it in slotReturnPressed (as it seems to me that shit+return > > also invokes it?) > > Saheb Preet Singh wrote: > yes slotReturnPressed tracks s

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-02 Thread Jonathan Doman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Jan. 3, 2014, 2:24 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-02 Thread Jonathan Doman
> On Dec. 29, 2013, 7:44 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 203 > > > > > > I'd like if you kept the OpenInNewTab/OpenInNewShell in a configuration > > setting so people were not forced to