[Okular-devel] Epub - webkit, getting text bounds

2013-06-02 Thread Jaydeep Solanki
Hi, While working on getting text bounds work I discovered that QWebFrame::hitTestContent(QPoint()) hits the outermost element, inside body. Consider the below HTML, some text... ... some other text.. Now we have two QPoints; QPoint pt1 => which points somewhere within p1 QPoint pt2 => which p

Re: [Okular-devel] Epub - webkit, getting text bounds

2013-06-02 Thread Albert Astals Cid
El Dilluns, 3 de juny de 2013, a les 01:52:04, Jaydeep Solanki va escriure: > Hi, > While working on getting text bounds work I discovered that > QWebFrame::hitTestContent(QPoint()) hits the outermost element, inside body. > > Consider the below HTML, > > > some text... > ... > some other text..

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-02 Thread Albert Astals Cid
> On June 1, 2013, 3:40 p.m., Albert Astals Cid wrote: > > Looks good for me besides one small thing, in editFormList and > > editFormCombo you are passing the "old" values while in editFormText and > > editFormButtons you are not (you get them from the forms themselves) is it > > possible not

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-02 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/ --- (Updated June 3, 2013, 1:28 a.m.) Review request for Okular. Changes ---

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-02 Thread Jon Mease
> On June 1, 2013, 3:40 p.m., Albert Astals Cid wrote: > > Looks good for me besides one small thing, in editFormList and > > editFormCombo you are passing the "old" values while in editFormText and > > editFormButtons you are not (you get them from the forms themselves) is it > > possible not