[Okular-devel] [Bug 209620] okular does not respect print queue defaults

2010-03-30 Thread Frans Leerink
https://bugs.kde.org/show_bug.cgi?id=209620 Frans Leerink changed: What|Removed |Added CC||f.leer...@xs4all.nl --- Comment #8 from Fra

[Okular-devel] [Bug 177213] High X server memory consumption

2010-03-30 Thread Fest
https://bugs.kde.org/show_bug.cgi?id=177213 --- Comment #34 from Fest 2010-03-30 18:01:12 --- "MemoryLevel" option "Low" draining memory too. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the

[Okular-devel] [Bug 232672] New: Okular crashed while scrolling down the document

2010-03-30 Thread Alberto Quattrini Li
https://bugs.kde.org/show_bug.cgi?id=232672 Summary: Okular crashed while scrolling down the document Product: okular Version: unspecified Platform: Unlisted Binaries OS/Version: Linux Status: UNCONFIRMED Severity: crash

[Okular-devel] [Bug 217135] When i try open fb2 book okular crash

2010-03-30 Thread mityi
https://bugs.kde.org/show_bug.cgi?id=217135 --- Comment #8 from mityi 2010-03-29 22:02:54 --- Created an attachment (id=42359) --> (http://bugs.kde.org/attachment.cgi?id=42359) it's file that causes this crash -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You

[Okular-devel] [Bug 209620] okular does not respect print queue defaults

2010-03-30 Thread Roderick Johnstone
https://bugs.kde.org/show_bug.cgi?id=209620 --- Comment #9 from Roderick Johnstone 2010-03-30 14:46:23 --- @Frans: This is all fixed in kde 4.4, and the qt library version it requires. Of course you may have to wait for this to be released in your distro unless you built it yourself. --

[Okular-devel] [Bug 217135] When i try open fb2 book okular crash

2010-03-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=217135 Albert Astals Cid changed: What|Removed |Added CC||to...@kde.org --- Comment #9 from Alber

[Okular-devel] [Bug 232672] Okular crashed while scrolling down the document

2010-03-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=232672 --- Comment #1 from Albert Astals Cid 2010-03-30 22:15:24 --- Does it always crash with the same pdf? -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee fo

[Okular-devel] Krazy: Check for strings used improperly or should be i18n

2010-03-30 Thread Glen Kaukola
Hey, Here's the start of a few of krazy fixes. This one passes QLatin1String's to QString::startsWith() and endsWith() methods.Index: okular/core/fileprinter.cpp === --- okular/core/fileprinter.cpp (revision 1109126) +++ okular/core/

[Okular-devel] Krazy: Check for Qt classes that should not be used.

2010-03-30 Thread Glen Kaukola
Patch to turn Q classes in to K classes.Index: okular/conf/dlgeditorbase.ui === --- okular/conf/dlgeditorbase.ui (revision 1109126) +++ okular/conf/dlgeditorbase.ui (working copy) @@ -27,7 +27,7 @@ - +

[Okular-devel] Krazy: Check for spelling errors

2010-03-30 Thread Glen Kaukola
Fixes a few spelling errors in the comments.Index: okular/core/textpage.cpp === --- okular/core/textpage.cpp (revision 1109126) +++ okular/core/textpage.cpp (working copy) @@ -483,7 +483,7 @@ // move the current po

[Okular-devel] Krazy: Check for Qt classes that should not be used.

2010-03-30 Thread Glen Kaukola
More Q classes to K classes.Index: okular/ui/formwidgets.cpp === --- okular/ui/formwidgets.cpp (revision 1109126) +++ okular/ui/formwidgets.cpp (working copy) @@ -299,7 +299,7 @@ FormLineEdit::FormLineEdit( Okular::FormFieldText *

[Okular-devel] Krazy: Check for assignments to QString::null

2010-03-30 Thread Glen Kaukola
Replaces QString() assignments with .clear().Index: okular/extensions.cpp === --- okular/extensions.cpp (revision 1109126) +++ okular/extensions.cpp (working copy) @@ -84,7 +84,7 @@ { type = KParts::LiveConnectExtension::

[Okular-devel] Krazy: Check for C++ ctors that should be declared 'explicit'

2010-03-30 Thread Glen Kaukola
Makes a few ctors explicit.Index: okular/generators/fax/faxdocument.h === --- okular/generators/fax/faxdocument.h (revision 1109126) +++ okular/generators/fax/faxdocument.h (working copy) @@ -33,7 +33,7 @@ * * @param type T

[Okular-devel] Krazy: Check single-char QString operations for efficiency

2010-03-30 Thread Glen Kaukola
Turns single char QStrings into QChars.Index: okular/core/fileprinter.cpp === --- okular/core/fileprinter.cpp (revision 1109224) +++ okular/core/fileprinter.cpp (working copy) @@ -601,7 +601,7 @@ if ( dialogOptions[i+1].isEmpt

[Okular-devel] [Bug 232672] Okular crashed while scrolling down the document

2010-03-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=232672 --- Comment #3 from Albert Astals Cid 2010-03-30 23:25:54 --- And if you open again the same pdf does it crash again? -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are

Re: [Okular-devel] Krazy: Check for strings used improperly or should be i18n

2010-03-30 Thread Albert Astals Cid
A Dimarts, 30 de març de 2010, Glen Kaukola va escriure: > Hey, > > Here's the start of a few of krazy fixes. > > This one passes QLatin1String's to QString::startsWith() and endsWith() > methods. I disagree with this, makes the code more difficult to read and none of that are hot paths so the

Re: [Okular-devel] Krazy: Check for Qt classes that should not be used.

2010-03-30 Thread Albert Astals Cid
A Dimarts, 30 de març de 2010, Glen Kaukola va escriure: > Patch to turn Q classes in to K classes. If you have tested and there is no regression, this can go in. Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/lis

Re: [Okular-devel] Krazy: Check for spelling errors

2010-03-30 Thread Albert Astals Cid
A Dimarts, 30 de març de 2010, Glen Kaukola va escriure: > Fixes a few spelling errors in the comments. Ok. Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Krazy: Check for Qt classes that should not be used.

2010-03-30 Thread Albert Astals Cid
A Dimarts, 30 de març de 2010, Glen Kaukola va escriure: > More Q classes to K classes. If you have tested and it works i see no problem with the patch. Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okul

Re: [Okular-devel] Krazy: Check for assignments to QString::null

2010-03-30 Thread Albert Astals Cid
A Dimarts, 30 de març de 2010, Glen Kaukola va escriure: > Replaces QString() assignments with .clear(). Disagree, personally i like QString() much better over clear, so rejected. On a side note (d->m_docFileName).clear(); is a weird syntax. Albert __

Re: [Okular-devel] Krazy: Check for C++ ctors that should be declared 'explicit'

2010-03-30 Thread Albert Astals Cid
A Dimarts, 30 de març de 2010, Glen Kaukola va escriure: > Makes a few ctors explicit. Ok. Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Krazy: Check single-char QString operations for efficiency

2010-03-30 Thread Albert Astals Cid
A Dimarts, 30 de març de 2010, Glen Kaukola va escriure: > Turns single char QStrings into QChars. If there is no regression introduced, ok with it. Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-d