Re: refactoring in pageview class

2017-02-19 Thread Albert Astals Cid
El dimecres, 15 de febrer de 2017, a les 11:23:58 CET, Oliver Sander va escriure: > > Personally I'm not very happy about refactorings, usually they just end up > > either: * Causing regressions because there's a corner case the > > refactoring didn't think of * Being as complex as the original co

refactoring in pageview class

2017-02-15 Thread Oliver Sander
> Personally I'm not very happy about refactorings, usually they just end up > either: > * Causing regressions because there's a corner case the refactoring didn't > think of > * Being as complex as the original code, because original code is complex for > a reason. I see your point. On the ot

Re: refactoring in pageview class

2017-02-14 Thread Jonathan Schultz
OK I stand corrected about other applications. But still must agree with hb that Okular makes it difficult to know how to get out of full-screen. Sure, people who are committed users of KDE probably know Ctrl-Shift-F, but Okular is really a basic application that is widely used by beginners (i

Re: refactoring in pageview class

2017-02-13 Thread habruening
Hi Albert! Please open okular in fullscreen mode and ask your wife or girl friend or your neighbour how to come out of this mode. I don't ask you to give up Ctrl+Chift+F. Kate has a button "close fullscreen". Firefox opens the toolbar and window title when mouse cusor moves to the upper corne

Re: refactoring in pageview class

2017-02-13 Thread Albert Astals Cid
El dimarts, 14 de febrer de 2017, a les 11:04:11 CET, Jonathan Schultz va escriure: > >> My personal interest stems from having forked okular for my own project > >> (https://github.com/jschultz/okular-tagging), > > > > You've relicensed all of the code to GPL-3 ? > > Not really thought about it

Re: refactoring in pageview class

2017-02-13 Thread Jonathan Schultz
My personal interest stems from having forked okular for my own project (https://github.com/jschultz/okular-tagging), You've relicensed all of the code to GPL-3 ? Not really thought about it, just used GPL-3 as a default licence. Not sure that's illegal but for sure makes cherry-picking chan

Re: refactoring in pageview class

2017-02-13 Thread Albert Astals Cid
El dimarts, 14 de febrer de 2017, a les 10:26:35 CET, Jonathan Schultz va escriure: > Hear hear! > > PageView really is a a mess, I presume because it has been repeatedly > added to as okular has grown from kpdf and never been subject to a > proper clean-up. Notably (and in addition to the > Page

Re: refactoring in pageview class

2017-02-13 Thread Albert Astals Cid
El dilluns, 13 de febrer de 2017, a les 21:13:55 CET, habruening va escriure: > Hi Okular developers! > > I am trying to start with KDE development. It is my first open source > initiative. I think, Okular is an interesting point to start. My first > patch (https://git.reviewboard.kde.org/r/129773

Re: refactoring in pageview class

2017-02-13 Thread Albert Astals Cid
El dimarts, 14 de febrer de 2017, a les 10:26:35 CET, Jonathan Schultz va escriure: > Hear hear! > > PageView really is a a mess, I presume because it has been repeatedly > added to as okular has grown from kpdf and never been subject to a > proper clean-up. Notably (and in addition to the > Page

Re: refactoring in pageview class

2017-02-13 Thread Jonathan Schultz
Hear hear! PageView really is a a mess, I presume because it has been repeatedly added to as okular has grown from kpdf and never been subject to a proper clean-up. Notably (and in addition to the PageView/PageViewPrivate confusion you mention), it has massively long functions (eg mouseReleas

refactoring in pageview class

2017-02-13 Thread habruening
Hi Okular developers! I am trying to start with KDE development. It is my first open source initiative. I think, Okular is an interesting point to start. My first patch (https://git.reviewboard.kde.org/r/129773/) was not accepted. Anyway, I carry on. I think, I could try some code cleanup work.