Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-07 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129099/ --- (Updated Oct. 7, 2016, 4:31 p.m.) Status -- This change has been dis

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-07 Thread Martin Tobias Holmedahl Sandsmark
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? > > Oliver Sander wrote: > I see three benefits: > a) I can see by looking at the

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-06 Thread Albert Astals Cid
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? > > Oliver Sander wrote: > I see three benefits: > a) I can see by looking at the

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-05 Thread Oliver Sander
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? > > Oliver Sander wrote: > I see three benefits: > a) I can see by looking at the

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-04 Thread Oliver Sander
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? I see three benefits: a) I can see by looking at the declaration of m_drawingEngine that

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129099/#review99787 --- I honestly don't see the benefit You changed a delete by a r

Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-04 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129099/ --- Review request for Okular. Repository: okular Description --- Beca