---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---
(Updated Sept. 26, 2017, 9:28 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---
(Updated Sept. 26, 2017, 8:42 p.m.)
Review request for Okular, KDE Usabil
> On set. 17, 2017, 10:20 a.m., Elvis Angelaccio wrote:
> > Ping? Or should I re-upload the patch on phabricator for better visibility?
>
> Albert Astals Cid wrote:
> Code is still wrong, what more visibility do you want? If you're not
> going to allow for yes/no, why do you need a roundtri
> On Септ. 17, 2017, 1:20 след обяд, Elvis Angelaccio wrote:
> > Ping? Or should I re-upload the patch on phabricator for better visibility?
>
> Albert Astals Cid wrote:
> Code is still wrong, what more visibility do you want? If you're not
> going to allow for yes/no, why do you need a rou
> On set. 17, 2017, 10:20 a.m., Elvis Angelaccio wrote:
> > Ping? Or should I re-upload the patch on phabricator for better visibility?
Code is still wrong, what more visibility do you want? If you're not going to
allow for yes/no, why do you need a roundtrip to the ui to decide to continue
th
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review103715
---
Ping? Or should I re-upload the patch on phabricator for bet
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---
(Updated Aug. 30, 2017, 2:47 p.m.)
Review request for Okular, KDE Usabili
> On feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way
> > to do it, if we're going to continue searching anyways, don't send a
> > Okular::Document::EndOfDocumentReached, just continue searching.
>
> Elvis Angela
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way
> > to do it, if we're going to continue searching anyways, don't send a
> > Okular::Document::EndOfDocumentReached, just continue searching.
>
> Elvis Angela
> On March 19, 2017, 10:30 p.m., Thomas Pfeiffer wrote:
> > Great idea!
> > The only feedback I have is that currently the message is visually detached
> > from the search bar (which the user is likely to focus on at this point
> > because that's where they've just clicked a button).
> > Could
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102908
---
Great idea!
The only feedback I have is that currently the m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---
(Updated March 11, 2017, 5:41 p.m.)
Review request for Okular, KDE Usabil
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102793
---
Someone from accessibility: ping?
- Albert Astals Cid
On
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way
> > to do it, if we're going to continue searching anyways, don't send a
> > Okular::Document::EndOfDocumentReached, just continue searching.
>
> Elvis Angela
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---
(Updated Feb. 9, 2017, 10:08 p.m.)
Review request for Okular, KDE Usabili
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way
> > to do it, if we're going to continue searching anyways, don't send a
> > Okular::Document::EndOfDocumentReached, just continue searching.
>
> Elvis Angela
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way
> > to do it, if we're going to continue searching anyways, don't send a
> > Okular::Document::EndOfDocumentReached, just continue searching.
Should we ask in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102350
---
i'm not sure i agree with this change, but this doesn't seem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---
(Updated Feb. 1, 2017, 11:20 p.m.)
Review request for Okular and Albert A
19 matches
Mail list logo
