Re: Need help in getting started with writing the integration test

2018-06-09 Thread Tobias Deiminger
Am 09.06.2018 12:46 schrieb Dileep Sankhla :On Sat, Jun 9, 2018 at 1:43 AM Tobias Deiminger wrote:Am 08.06.2018 18:57 schrieb Dileep Sankhla: > Hello Tobias, > > I have succeeded in getting the QInputDialog to write a new note: > > QMetaObject::invokeMethod(part.m_pageView, "

Re: Need help in getting started with writing the integration test

2018-06-09 Thread Dileep Sankhla
On Sat, Jun 9, 2018 at 1:43 AM Tobias Deiminger wrote: > Am 08.06.2018 18:57 schrieb Dileep Sankhla: > > Hello Tobias, > > > > I have succeeded in getting the QInputDialog to write a new note: > > > > QMetaObject::invokeMethod(part.m_pageView, "slotToggleAnnotator", > > Q_ARG( bool, true )); //

Re: Need help in getting started with writing the integration test

2018-06-09 Thread Tobias Deiminger
Am 08.06.2018 18:57 schrieb Dileep Sankhla: Secondly, I'm doing like this to create and add a typewriter annotation to page: part.m_document->setViewportPage(0); Okular::Annotation * annot = nullptr; Okular::TextAnnotation * ta = new Okular::TextAnnotation(); annot = ta; ta->setFlags( ta->flags

Re: Need help in getting started with writing the integration test

2018-06-08 Thread Tobias Deiminger
Am 08.06.2018 18:57 schrieb Dileep Sankhla: Hello Tobias, I have succeeded in getting the QInputDialog to write a new note: QMetaObject::invokeMethod(part.m_pageView, "slotToggleAnnotator", Q_ARG( bool, true )); // displayes the annotation toolbar QList toolbuttonList = part.m_pageView->findCh

Re: Need help in getting started with writing the integration test

2018-06-08 Thread Dileep Sankhla
Hello Tobias, I have succeeded in getting the QInputDialog to write a new note: QMetaObject::invokeMethod(part.m_pageView, "slotToggleAnnotator", Q_ARG( bool, true )); // displayes the annotation toolbar QList toolbuttonList = part.m_pageView->findChildren(); // Get the list of all 10 annotation

Re: Need help in getting started with writing the integration test

2018-06-08 Thread Dileep Sankhla
Thank you. I have created a single test case for the typewriter toolbutton and have pushed it to the gsoc2018_typewriter branch. I have defined 3 test cases as follows: 1. Check if the toolbar buttons contain the "Typewriter" button - Done 2. Click the typewriter button, start PickPointEngine engi

Re: Need help in getting started with writing the integration test

2018-06-06 Thread Tobias Deiminger
Am 06.06.2018 23:17 schrieb Albert Astals Cid: El dimecres, 6 de juny de 2018, a les 15:43:01 CEST, Dileep Sankhla va escriure: PageViewAnnotator pageviewannotator(part.m_pageView, part.m_document); pageviewannotator.setEnabled( true ); Why don't you just call PageView::slotToggleAnnotator ?

Re: Need help in getting started with writing the integration test

2018-06-06 Thread Albert Astals Cid
El dimecres, 6 de juny de 2018, a les 15:43:01 CEST, Dileep Sankhla va escriure: > I'm adding my test to autotests/parttest.cpp with a test function > PartTest::testTypewriterAnnotTool. > For the annotation toolbar, I have #include "../ui/pageviewannotator.h" and > doing this in the test function:

Re: Need help in getting started with writing the integration test

2018-06-06 Thread Dileep Sankhla
I'm adding my test to autotests/parttest.cpp with a test function PartTest::testTypewriterAnnotTool. For the annotation toolbar, I have #include "../ui/pageviewannotator.h" and doing this in the test function: PageViewAnnotator pageviewannotator(part.m_pageView, part.m_document); pageviewannotator

Re: Need help in getting started with writing the integration test

2018-06-06 Thread Dileep Sankhla
Hello Tobias, Thank you so much for the detailed explanation. I got the overview of how tests are written and how they are currently organized. I have just begun to write the test for typewriter annotation tool and my first test case is "checking if the annotation toolbar has the typewriter tool

Re: Need help in getting started with writing the integration test

2018-06-03 Thread Tobias Deiminger
Am 03.06.2018 21:39 schrieb Tobias Deiminger: Am 03.06.2018 08:05 schrieb Dileep Sankhla: Ups, I misread the question What will I compare here? as "what will compare here?" GUI tests compare with autotests/parttest.cpp. Core tests potentially compare with autotests/*annot*.cpp Afaikt there

Re: Need help in getting started with writing the integration test

2018-06-03 Thread Tobias Deiminger
Hello Dileep Am 03.06.2018 08:05 schrieb Dileep Sankhla: Hello everyone, @everyone: Please correct me if I'm wrong or if you have other/better ideas. I have created a revision[0] for adding the typewriter annotation tool to Okular and now I need to write the integration test for the same.