davidedmundson added a comment.
Oops, I didn't read that. :/ Sorry.
cherry-picked.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8832
To: davidedmundson, rkflx
Cc: rkflx, sander, ngraham, #okular, gassaf, aacid
rkflx added a comment.
> Closed by commit
https://phabricator.kde.org/R223:1a3dc7d8e05fe0cd2d83ad5ed6365045e3f8e202
While `master` is quite "stable", I meant `Applications/17.12`, of course ;)
Will cherry-pick tomorrow…
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:1a3dc7d8e05f: Fix highlight/annotation clipping with Qt
scaling (authored by davidedmundson).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8832?vs=22420&id=22862
rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.
LGTM, solves the bug for me too and I could not break anything when testing.
As nobody brought up any issues so far, I'd say this can land (stable branch).
REPOSITORY
R223 Okular
BRANCH
sander added a comment.
Thanks for the patch. It seems to solve the problem for me.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8832
To: davidedmundson
Cc: sander, ngraham, #okular, aacid
davidedmundson created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
pixelValue/pixelValue will give us a normalised value.
Normalised values shouldn't be modified by a device pixel ratio.
We want scaledR
