D8690: Fix use of OpenUrlArguments

progwolff closed this revision. progwolff added a comment. Thanks! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, michaelweghorn, ngraham, aacid

D8690: Fix use of OpenUrlArguments

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Ok, i'll commit that version. REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, michaelweghorn, ngra

D8690: Fix use of OpenUrlArguments

progwolff added a comment. I would like to revert to Diff 22028. See my message from Nov 7 2017, 15:11 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, michaelweghorn, ngraham, aacid

D8690: Fix use of OpenUrlArguments

aacid added a comment. In D8690#211780 , @progwolff wrote: > @aacid Can we agree to revert to https://phabricator.kde.org/D8690?id=22028 and land this to get the bug fixed? https://phabricator.kde.org/D8690?id=22028 just links to this revi

D8690: Fix use of OpenUrlArguments

progwolff added a comment. @aacid Can we agree to revert to https://phabricator.kde.org/D8690?id=22028 and land this to get the bug fixed? I'll set the test case you requested on my todo list. We will need to define the prefered behaviour first and would need to do some changes to Oku

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > progwolff wrote in part.cpp:1400 > Sorry for the delay... > > From my understanding of that commit, my changes won't break it. > argMime is only set, if an external application sets the mimeType via > OpenUrlArguments. So, the order in 1355 is

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1400 > I don't think this is a good idea, do you have an actual case in which this > helps or is it just a guess? > > Also have you tried that this doesn't break the fixes that > https://phabricator.kde.org/R223:fba9067

D8690: Fix use of OpenUrlArguments

aacid added inline comments. INLINE COMMENTS > progwolff wrote in part.cpp:1400 > I changed the order here. > Now mime types defined by OpenUrlArguments are prefered. This allows opening > files with wrong endings by forcing the right mime type. I don't think this is a good idea, do you have an

D8690: Fix use of OpenUrlArguments

progwolff updated this revision to Diff 22039. progwolff added a comment. - prefer mime type given by OpenUrlArguments - add test for choosing backend by mime type REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8690?vs=22028&id=22039 BRANCH Applications

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > part.cpp:1400 > { > -mimes << pathMime << argMime; > +mimes << argMime << pathMime; > } I changed the order here. Now mime types defined by OpenUrlArguments are prefered. This allows opening files with

D8690: Fix use of OpenUrlArguments

progwolff added a comment. Right, this might be worth a test too. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

aacid added a comment. Not sure that's the test we really want, i mean what we really want to check is that the proper backend was opened, no? I mean maybe what makes sense is to set the mimetype to txt and then giving it a pdf file and checking that the txt backend was used instead of t

D8690: Fix use of OpenUrlArguments

progwolff updated this revision to Diff 22028. progwolff added a comment. - add autotest REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8690?vs=22020&id=22028 BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D8690 AFFECTED FILES

D8690: Fix use of OpenUrlArguments

aacid added a comment. interesting, could you try to add an autotest for this? Seems like something that is a bit fragile and may break in the future depending on how we rework stuff in part.cpp (there's a big-ish rework coming for saveas) REPOSITORY R223 Okular REVISION DETAIL https://

D8690: Fix use of OpenUrlArguments

progwolff edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8690 To: progwolff, aacid Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

progwolff created this revision. progwolff added a reviewer: aacid. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY BUG: 386600 Applications using Okular as a KPart might set a file's mime type in the OpenUrlArguments. O