D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

This revision was automatically updated to reflect the committed changes. Closed by commit R223:19f22098e67d: Mind the devicePixelRatio when drawing on-screen in presentation mode (authored by sander). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21836?vs=601

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

tobiasdeiminger accepted this revision. tobiasdeiminger added a comment. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular, ngraham, tobiasdeiminger Cc: okular-devel, fbampaloukas, joaonetto, tfel

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander updated this revision to Diff 60149. sander marked an inline comment as done. sander added a comment. - Use `localPos` instead of `screenPos` - Factor out intermediate Pixmap size computations - Use `QPainterPath` for smoother paths REPOSITORY R223 Okular CHANGES SINCE LAST UPDAT

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander marked an inline comment as done. sander added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in presentationwidget.cpp:900 > Maybe use a scoped > > const QSizeF pmSize { geom.width() * dpr, geom.height() * dpr }; > > instead of repeatedly recalculating width and height? Oka

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

ngraham added a comment. I don't have one, sorry. LGTM as-is though. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular, ngraham, tobiasdeiminger Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

tobiasdeiminger added a comment. In D21836#482214 , @sander wrote: > Ping? Nice patch. Maybe someone with a real HiDPI setup (I can only fake it) should have a look at it too. REPOSITORY R223 Okular REVISION DETAIL https://phabricat

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

tobiasdeiminger added inline comments. INLINE COMMENTS > presentationwidget.cpp:900 > > -QPixmap pm( geom.size() ); > +QPixmap pm( QSize( geom.size().width() * dpr, geom.size().height() * > dpr ) ); > pm.fill( Qt::transparent ); Maybe use a scoped const QSizeF pmSi

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander added a comment. Path quality gets even better (slightly) if I replace the sequence of lines drawn by `SmoothPathEngine` with a `QPainterPath`. Do you prefer this change right here or in a separate patch on top? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander added reviewers: ngraham, tobiasdeiminger. sander added a comment. Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular, ngraham, tobiasdeiminger Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY Previously, when using a screen scaling factor larger than 1, the drawings by mouse or stylus in pre