D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Albert Astals Cid
aacid added a comment. In D21630#475517 , @ndavis wrote: > In D21630#475501 , @aacid wrote: > > > **wow** Not even one minute to review things > > > > I don't particularly like this, input-mouse i

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis added a comment. @aacid `transform-move` is less correct, but it's in Oxygen and Papirus (not Adwaita). Would you prefer if that icon was used? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21630 To: ndavis, #okular, #vdg, ngraham Cc: aacid, ngraham, okular-

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis added a comment. In D21630#475501 , @aacid wrote: > **wow** Not even one minute to review things > > I don't particularly like this, input-mouse is an icon that exists in most icon themes > extra/adwaita-icon-theme > extra/breeze

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Albert Astals Cid
aacid added a comment. **wow** Not even one minute to review things I don't particularly like this, input-mouse is an icon that exists in most icon themes extra/adwaita-icon-theme extra/breeze-icons extra/efl extra/gnome-icon-theme extra/gnome-icon-theme-symbolic extra/gnome-t

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R223:9310bed61621: Change Browse icon back to the hand shape (authored by ndavis). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21630?vs=59275&id=59278 REVISION DETAIL

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R223 Okular BRANCH fix-browse-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21630 To: ndavis, #okular, #vdg, ngraham Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, `transform-browse` is a more semantically correct icon anyway. REPOSITORY R223 Okular BRANCH fix-browse-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. ndavis requested review of this revision. REVISION SUMMARY I changed the `input-mouse` icon so that it would look more like a real mouse. In order to keep