D18744: Add action in Edit menu to select the current page

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

D18744: Add action in Edit menu to select the current page

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

D18744: Add action in Edit menu to select the current page

michaelweghorn added a comment. In D18744#412409 , @michaelweghorn wrote: > The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments

D18744: Add action in Edit menu to select the current page

michaelweghorn added a comment. The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) Can you update the description accor

D18744: Add action in Edit menu to select the current page

shubham retitled this revision from "[RFC]Add action in Edit menu to select the current page" to "Add action in Edit menu to select the current page". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts,

D18744: Add action in Edit menu to select the current page

shubham updated this revision to Diff 51685. shubham marked 3 inline comments as done. shubham retitled this revision from "Add action in Edit menu to select the current page " to "Add action in Edit menu to select the current page". shubham added a comment. Add action to part.rc Bump versio

D18744: Add action in Edit menu to select the current page

loh.tar added inline comments. INLINE COMMENTS > shubham wrote in pageview.cpp:743 > So better I will remove that. Here is e.g. Alt-P, and a couple of F-Keys not used. But perhaps exist in other software some similar function with a usual key sequence that can be adopt REPOSITORY R223 Okula

D18744: Add action in Edit menu to select the current page

shubham added inline comments. INLINE COMMENTS > ngraham wrote in pageview.cpp:743 > It doesn't have a shortcut at all. If you can't think of anything that > doesn't conflict, then just don't give it one. So better I will remove that. REPOSITORY R223 Okular REVISION DETAIL https://phabric

D18744: Add action in Edit menu to select the current page

ngraham added inline comments. INLINE COMMENTS > shubham wrote in pageview.cpp:743 > What sequence should I use? It doesn't have a shortcut at all. If you can't think of anything that doesn't conflict, then just don't give it one. REPOSITORY R223 Okular REVISION DETAIL https://phabricator

D18744: Add action in Edit menu to select the current page

shubham added inline comments. INLINE COMMENTS > ngraham wrote in pageview.cpp:743 > Erm, that's the shortcut used for printing. Did you test this? What sequence should I use? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: k

D18744: Add action in Edit menu to select the current page

ngraham added a comment. In D18744#411621 , @shubham wrote: > I knew ctrl p is for print, so for time being I kept it so I can get suggestion for other shortcut sequence. It's not acceptable to deliberately publish a diff that does the wr

D18744: Add action in Edit menu to select the current page

shubham added a comment. In D18744#411599 , @ngraham wrote: > Please test your changes. The new menu is not actually added to the Edit menu and the shortcut you chose conflicts with the print shortcut. I knew ctrl p is for print, so for t

D18744: Add action in Edit menu to select the current page

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Please test your changes. The new menu is not actually added to the Edit menu and the shortcut you chose conflicts with the print shortcut. INLINE COMMENTS > pageview.cpp:740 >

D18744: Add action in Edit menu to select the current page

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

D18744: Add action in Edit menu to select the current page

shubham retitled this revision from "Add action in Edit menu to select the entire page " to "Add action in Edit menu to select the current page ". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.