D18719: [WIP]Create context menu entry to rotate individual pages

davidhurka added a comment. Sometimes I think it makes sense to move the context menu to the widget it belongs to. That widget would accept the context menu event, and create a context menu. Basically the same context menu that is currently created by Part. Because PageView will create t

D18719: [WIP]Create context menu entry to rotate individual pages

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D18719: [WIP]Create context menu entry to rotate individual pages

aacid added a comment. In D18719#414068 , @shubham wrote: > How do I resolve this? Don't use the private class, what made you think you can use the private class? it's *private* so obviously it's non usable (unless you know what you're d

D18719: [WIP]Create context menu entry to rotate individual pages

shubham added a comment. How do I resolve this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18719: [WIP]Create context menu entry to rotate individual pages

aacid added a comment. The code doesn't link. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18719: [WIP]Create context menu entry to rotate individual pages

shubham updated this revision to Diff 51520. shubham added a comment. use rotateAt() REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18719?vs=51269&id=51520 BRANCH page REVISION DETAIL https://phabricator.kde.org/D18719 AFFECTED FILES core/page.h p

D18719: [WIP]Create context menu entry to rotate individual pages

shubham added a comment. @aacid I'm unsure whether rotateAt() function will actually work, any suggestions you can give? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18719: [WIP]Create context menu entry to rotate individual pages

shubham added inline comments. INLINE COMMENTS > part.cpp:2451 > +int value = ( page->rotation() + 3 ) % 4; > +m_pagePrivate->rotateAt( qobject_cast(value) ); > +} This is valid statement, but why does this produce error? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.k

D18719: [WIP]Create context menu entry to rotate individual pages

shubham retitled this revision from "[RFC]Create context menu entry to rotate individual pages" to "[WIP]Create context menu entry to rotate individual pages". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ng