D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-31 Thread Nathaniel Graham
ngraham added a comment. In D18623#402978 , @ognarb wrote: > Ok, thanks for the suggestion I will try to look how to create a better dark theme patch when I have time :D Or a dedicated "reading mode" or "night mode" would be nice too! RE

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-31 Thread Carl Schwan
ognarb abandoned this revision. ognarb added a comment. Ok, thanks for the suggestion I will try to look how to create a better dark theme patch when I have time :D REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular, ngraham Cc: davidhurka, ema

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-31 Thread David Hurka
davidhurka added a comment. In D18623#402834 , @emateli wrote: > Perhaps this patch might not be it, but Okular does actually need a "Night Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers like @filipf suggests.

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-31 Thread Emirald Mateli
emateli added a comment. Perhaps this patch might not be it, but Okular does actually need a "Night Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers like @filipf suggests. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb,

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-31 Thread Carl Schwan
ognarb added a comment. My use case is that I contently switch between breeze and breeze dark with a script that call `lookandfeeltool` and change Konsole colorscheme. So I wanted that more parts of my system could adapt to this script. I could probably also hack something so that it use the

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Filip Fila
filipf added a comment. Reading PDFs can be a bit painful in the dark, especially if your eyes are already tired. (I sometimes use KWin's Invert effect to help me out). So do I see the benefit in this, but only as a night mode of sorts. REPOSITORY R223 Okular REVISION DETAIL https://pha

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I agree, there is no chance anyone would want to use this. As your video demonstrates, contrast is terrible with all color schemes (especially Oxygen) and would cause severe eye

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Albert Astals Cid
aacid added a comment. This makes no sense. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular Cc: aacid, okular-devel, tfella, ngraham, darcyshen

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Carl Schwan
ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY This mode use the QPalette to find a background and foreground color. TEST PLAN Tested manually, all the other render mode still wo

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid