D18358: Add buttons to collapse and expand all elements

2019-05-25 Thread David Hurka
davidhurka added inline comments. INLINE COMMENTS > side_reviews.cpp:156 > +connect(expandAll, &QAction::triggered, this, &Reviews::slotExpandAll); > +QAction * collapseAll = toolBar->addAction( QIcon::fromTheme( > QStringLiteral("collapse-all") ), i18n( "Collapse all elements" ) ); > +

D18358: Add buttons to collapse and expand all elements

2019-03-31 Thread Albert Astals Cid
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:b66939840440: Add buttons to collapse and expand all elements (authored by joaonetto, committed by aacid). REPOSITORY

D18358: Add buttons to collapse and expand all elements

2019-03-31 Thread Albert Astals Cid
aacid accepted this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto, #okular, #vdg, ngraham, aacid Cc: ndavis, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D18358: Add buttons to collapse and expand all elements

2019-03-12 Thread Joao Oliveira
joaonetto added a comment. Just added some screenshots with the results. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto, #okular, #vdg, ngraham Cc: ndavis, aacid, ngraham, okular-devel, tfella, darcyshen

D18358: Add buttons to collapse and expand all elements

2019-03-12 Thread Joao Oliveira
joaonetto edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto, #okular, #vdg, ngraham Cc: ndavis, aacid, ngraham, okular-devel, tfella, darcyshen

D18358: Add buttons to collapse and expand all elements

2019-03-12 Thread Noah Davis
ndavis added a comment. In D18358#429972 , @aacid wrote: > How does it look when you don't have latest breeze? You wouldn't get any icons for "collapse/expand all" buttons without the latest breeze-icons. REPOSITORY R223 Okular REVISI

D18358: Add buttons to collapse and expand all elements

2019-03-12 Thread Albert Astals Cid
aacid added a comment. How does it look when you don't have latest breeze? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto, #okular, #vdg, ngraham Cc: aacid, ngraham, okular-devel, tfella, darcyshen

D18358: Add buttons to collapse and expand all elements

2019-03-12 Thread Joao Oliveira
joaonetto retitled this revision from "[WIP] Add buttons to collapse and expand all elements" to "Add buttons to collapse and expand all elements". joaonetto edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto, #okular

D18358: Add buttons to collapse and expand all elements

2019-01-18 Thread Joao Oliveira
joaonetto created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. joaonetto requested review of this revision. REVISION SUMMARY Adds two buttons on the bottom right to expand and collapse all elements in annotations BUG: 377024 T8553