D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-18 Thread Joao Oliveira
joaonetto abandoned this revision. joaonetto added a comment. As discussed in T8553 , a button that does this would be more suitable. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18283 To: joaonetto Cc: simgunz, aacid, okular-dev

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-17 Thread Simone Gaiarin
simgunz added a comment. I use the side review panel only when I need to go through all the reviews one by one, so it is annoying having to expand all the elements by hand. Maybe a expand/collapse all solution would be a better solution. (The long answer is in T8553

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-17 Thread Simone Gaiarin
simgunz added a task: T8553: Improve review side panel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18283 To: joaonetto Cc: simgunz, aacid, okular-devel, tfella, ngraham, darcyshen

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-16 Thread Albert Astals Cid
aacid added a subscriber: simgunz. aacid added a comment. @simgunz can you explain why you wanted this in? Is this really an improvement in usage? I mean if you have only 3 reviews, i guess yes, but if you have 1000 over 500 pages you may prefer it to not be expanded? REPOSITORY R223

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-15 Thread Joao Oliveira
joaonetto updated this revision to Diff 49587. joaonetto added a comment. Updated files REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18283?vs=49586&id=49587 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18283 AFFECTED FILES part.cpp

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-15 Thread Joao Oliveira
joaonetto added a comment. Fixing it, other files went in. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18283 To: joaonetto Cc: aacid, okular-devel, tfella, ngraham, darcyshen

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-15 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > okular.kcfg:309 > > + > + Qt::yellow This seems to have sneaked form a different changeset. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18283 To: joaonetto Cc: aacid, okular-devel, tfella, ngraham, darcyshen

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

2019-01-15 Thread Joao Oliveira
joaonetto created this revision. joaonetto added a project: Okular. joaonetto requested review of this revision. REVISION SUMMARY When document is open, all the reviews are expanded in full form Bug: REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D