D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#450252 , @ngraham wrote: > OK, let's go for it! > > @michaelweghorn I hope you know this means you're on the hook to fix any bugs that crop up, right? :) @ngraham: Thanks for landing this! Yes

D18179: PDF: Implement scaling options for non-rasterized printing

ngraham added a comment. OK, let's go for it! @michaelweghorn I hope you know this means you're on the hook to fix any bugs that crop up, right? :) REPOSITORY R223 Okular BRANCH arcpatch-D18179 REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngrah

D18179: PDF: Implement scaling options for non-rasterized printing

This revision was automatically updated to reflect the committed changes. Closed by commit R223:748884b4c74d: PDF: Implement scaling options for non-rasterized printing (authored by michaelweghorn, committed by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kd

D18179: PDF: Implement scaling options for non-rasterized printing

aacid added a comment. i have not tested it, if you think it works, i guess it's ok from the pure code point of view. REPOSITORY R223 Okular BRANCH arcpatch-D18179 REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn marked 2 inline comments as done. REPOSITORY R223 Okular BRANCH arcpatch-D18179 REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 55394. michaelweghorn added a comment. Changes in this revision: - Update the '@since' comments from version 1.7 to 1.8 - Rename 'ScaleMode::None' to 'ScaleMode::NoScaling' REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabric

D18179: PDF: Implement scaling options for non-rasterized printing

aacid added inline comments. INLINE COMMENTS > fileprinter.h:58 > + * > + * @since 1.7 > + */ the since will need to be 1.8 (and all the other 1.7 you added) > fileprinter.h:61 > +enum ScaleMode { > +None = 0, > +FitToPrintArea = 1 Make this no Scale or somethin

D18179: PDF: Implement scaling options for non-rasterized printing

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All options work perfectly in my testing, both with and without rasterized printing enabled. If @aacid is good with the code, I think this could land. REPOSITORY R223 Okular BRANCH m

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#442948 , @ngraham wrote: > Never mind, removing the dependency made it work. Stupid Arc. :( Testing now... Yet, it also took me a while to figure this out... Looking forward to the GitLab migrati

D18179: PDF: Implement scaling options for non-rasterized printing

ngraham added a comment. Never mind, removing the dependency made it work. Stupid Arc. :( Testing now... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, dar

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn removed a dependency: D10974: Add option to ignore print margins for non-PDF generators. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshe

D18179: PDF: Implement scaling options for non-rasterized printing

ngraham added a comment. This patch no longer applies cleanly to master: Switched to branch 'master' Your branch is up to date with 'origin/master'. Already up to date. Deleted branch arcpatch-D18179 (was 8bf1a9117). INFO Base commit is not in local repository; trying t

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#394712 , @aacid wrote: > The only way i can think of is making the long form not havve default values > > https://paste.kde.org/p55lx6vrh Thanks, that looks good. I have done it this way now.

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 49715. michaelweghorn added a comment. Changes in this revision: - make new 'printFiles()' have no default values for parameters, so that param order can be the same as in the original one (thanks Albert!) - add "TODO" comment to merge bot

D18179: PDF: Implement scaling options for non-rasterized printing

aacid added a comment. In D18179#394328 , @michaelweghorn wrote: > If you have any other idea on how to avoid that issue with the printFiles() methods, I'd be thankful to hear about this. The only way i can think of is making the long fo

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. If you have any other idea on how to avoid that issue with the printFiles() methods, I'd be thankful to hear about this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvog

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#394030 , @aacid wrote: > We would need a @since marker for the enum and for the new methods and a > // TODO merge with function above when a BIC change happens somehwere else > would also make sense

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 49614. michaelweghorn marked an inline comment as done. michaelweghorn added a comment. - Adapt order of ScaleMode enum values as implicitly suggested in Albert's comment (I missed that at first) REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 49612. michaelweghorn retitled this revision from "PDF: Implement scaling for non-rasterized printing" to "PDF: Implement scaling options for non-rasterized printing". michaelweghorn edited the summary of this revision. michaelweghorn added a comment.