D17054: Retina Support for MacOS

2018-11-21 Thread René J . V . Bertin
rjvbb requested changes to this revision. rjvbb added a comment. This revision now requires changes to proceed. Actually, I realise this patch too is a somewhat stripped down version of a patch I've been using for a long time in my MacPorts packaging for Okular: https://github.com/RJVB/m

D17054: Retina Support for MacOS

2018-11-20 Thread René J . V . Bertin
rjvbb added a comment. This change does more than just enabling hidpi support in the plist. > Given you've been doing the same patch for multipple apps now, any chance this can be generated using an ECM macro, pernhaps populated from the app's desktop file or appstream data? Generat

D17054: Retina Support for MacOS

2018-11-20 Thread Kai Uwe Broulik
broulik added a comment. Given you've been doing the same patch for multipple apps now, any chance this can be generated using an ECM macro, pernhaps populated from the app's desktop file or appstream data? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17054 To: d

D17054: Retina Support for MacOS

2018-11-20 Thread Luigi Toscano
ltoscano added a comment. (Please fix the edit policy of the review, which is now too restricted) Also: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17054 To: darcyshen, #okul

D17054: Retina Support for MacOS

2018-11-20 Thread Darcy Shen
darcyshen created this revision. darcyshen added a reviewer: Okular. darcyshen created this object with edit policy "Administrators". Herald added a project: Okular. Herald added a subscriber: okular-devel. darcyshen requested review of this revision. TEST PLAN see https://github.com/KDE-mac/hom