D13114: Add DocumentRevision to Okular

chinmoyr abandoned this revision. chinmoyr added a comment. @aacid Sorry for late reply. This got lost in my inbox. This diff is not required. The relevant code for generating revision is already in poppler_generator. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.o

D13114: Add DocumentRevision to Okular

aacid added a comment. @chinmoyr What is this for? I didn't see it in your final branch, should it be discarded? Or it has some purpose? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13114 To: chinmoyr, aacid Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D13114: Add DocumentRevision to Okular

aacid added a comment. In D13114#269422 , @chinmoyr wrote: > The revision number starts from 1 and goes till the total number of signature form fields. This looks like a bit of implementation detail the UI developer has to know, in this

D13114: Add DocumentRevision to Okular

aacid added a comment. In D13114#269422 , @chinmoyr wrote: > In D13114#269280 , @aacid wrote: > > > Can you explain what's the use case for this? > > > Adobe reader allows user to view different

D13114: Add DocumentRevision to Okular

chinmoyr added a comment. In D13114#269280 , @aacid wrote: > Can you explain what's the use case for this? Adobe reader allows user to view different signed revisions of a PDF. This patch intends to implement that feature. > I thou

D13114: Add DocumentRevision to Okular

aacid added a comment. Can you explain what's the use case for this? I thought we had agreed that using qvariantmaps for passing structures was a bad idea. If i have to implement this for my AwesomeGenerator, how do i know what comes in revData? Also the API is weird, you have

D13114: Add DocumentRevision to Okular

chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch adds DocumentRevision class to Okular which stores in