This revision was automatically updated to reflect the committed changes.
Closed by commit R223:3e48663fb764: Use a target in FindDiscount (modern cmake)
rather than variables (authored by svuorela).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12672?vs=33515
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
It's actually fixing the build when discount is in its own prefix.
Also I agree that it's better using targets.
REPOSITORY
R223 Okular
BRANCH
Applications/18.04
REVISION DETAIL
http
aacid added a comment.
If noone disagrees i guess you can commit this in one week or so, i don't
really have enough knowledge to discuss if this is better or worse.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D12672
To: svuorela, kde-buildsystem
Cc: aacid, #okular
svuorela added a comment.
1. The current code only works if discount is installed into existing
locations (discount_INCLUDE_DIR is never used), and as a user of the
FindPackage, you don't have to care about the include directory. It comes from
the target.
2. The whole thing with targets vs
aacid added a comment.
It's more lines of code than before, what's the improvement?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D12672
To: svuorela, kde-buildsystem
Cc: aacid, #okular, ngraham
svuorela created this revision.
svuorela added a reviewer: kde-buildsystem.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
svuorela requested review of this revision.
TEST PLAN
Things still builds
REPOSITORY
R223 Okular
BRANCH
Application
