D10859: Improve layout of annotation configuration dialogs

simgunz added a comment. @sander Thanks. It worked. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: sander, davidhurka, aacid, okular-devel, knambiar, ngraham, fbampaloukas, joaonetto, tfella, darcyshen

D10859: Improve layout of annotation configuration dialogs

This revision was automatically updated to reflect the committed changes. Closed by commit R223:a33cb321df12: Improve layout of annotation configuration dialogs (authored by simgunz). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10859?vs=59534&id=60552 REVIS

D10859: Improve layout of annotation configuration dialogs

sander added a comment. I had the same problem yesterday and got around it by moving to https://invent.kde.org/kde/okular . REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: sander,

D10859: Improve layout of annotation configuration dialogs

simgunz added a comment. Tried to land this, but I got this error message: remote: FATAL: W refs/heads/master okular gaiarin DENIED by refs/.* remote: error: hook declined to update refs/heads/master To git.kde.org:okular ! [remote rejected] 6ee24b04e911da577f23a139c19e8

D10859: Improve layout of annotation configuration dialogs

simgunz edited the summary of this revision. REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, fbampaloukas, joaonetto, tfell

D10859: Improve layout of annotation configuration dialogs

simgunz added a comment. Perfect. I can land this tomorrow evening. REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, fbam

D10859: Improve layout of annotation configuration dialogs

aacid accepted this revision. REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, fbampaloukas, joaonetto, tfella, darcyshen

D10859: Improve layout of annotation configuration dialogs

aacid added a comment. had a quick look at the code and don't see anything obviosuly wrong, i'd say let's go for it Side note: i usually don't go over things that have been approved by someone else, so if you feel you really need my review when something has been approved please ping me

D10859: Improve layout of annotation configuration dialogs

simgunz added a comment. Just waiting for your OK. REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, fbampaloukas, joaonetto, tf

D10859: Improve layout of annotation configuration dialogs

aacid added a comment. Is this waiting on something or should it be commited? REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, f

D10859: Improve layout of annotation configuration dialogs

simgunz updated this revision to Diff 59534. simgunz added a comment. - Fix code formatting REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10859?vs=59533&id=59534 BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 AFFECT

D10859: Improve layout of annotation configuration dialogs

simgunz marked an inline comment as done. REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen

D10859: Improve layout of annotation configuration dialogs

simgunz updated this revision to Diff 59533. simgunz marked 3 inline comments as done. simgunz added a comment. - Properly cast QObject REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10859?vs=59532&id=59533 BRANCH fix-annot-config-dialog REVISION DETAIL

D10859: Improve layout of annotation configuration dialogs

shubham added inline comments. INLINE COMMENTS > annotationwidgets.cpp:818 > +QWidget * widget = (QWidget*)formlayout->parent(); > + > +addColorButton( widget, formlayout ); Why not qobject_cast? REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabr

D10859: Improve layout of annotation configuration dialogs

simgunz updated this revision to Diff 59532. simgunz marked 3 inline comments as done. simgunz added a comment. Fix author accelerator, remove 'for pdf only' tooltips REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10859?vs=59000&id=59532 BRANCH fix-annot-

D10859: Improve layout of annotation configuration dialogs

aacid added inline comments. INLINE COMMENTS > simgunz wrote in dlgannotationsbase.ui:55 > Yes. > > Both Author and Add had 'a' as accelerator. This was actually working. > Pressing 'a' twice switch between the two. > > Nonetheless I changed it to make the accelerators unique. > > Initially I

D10859: Improve layout of annotation configuration dialogs

simgunz updated this revision to Diff 59000. simgunz added a comment. - Change string that inform the user about how Identity info are used REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10859?vs=58965&id=59000 BRANCH fix-annot-config-dialog REVISION DET

D10859: Improve layout of annotation configuration dialogs

ngraham added a comment. > Replace “comments and reviews” by “annotations”. +1 REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: davidhurka, aacid, okular-devel, knambiar, ngraham, joao

D10859: Improve layout of annotation configuration dialogs

davidhurka added inline comments. INLINE COMMENTS > simgunz wrote in dlgannotationsbase.ui:71 > I have not understood the reason. This message is only displayed in the > configuration dialog. In any case we could change it for me. In D10859#472832 , @s

D10859: Improve layout of annotation configuration dialogs

simgunz added a comment. What should we do regarding the message at line 71 of conf/dlgannotationsbase.ui ? I think is the last thing to possibly change. After that I think this review is ready. Once I get the ok from @aacid I can land this. (The code for the stamp annotation is rea

D10859: Improve layout of annotation configuration dialogs

simgunz updated this revision to Diff 58965. simgunz added a comment. - Rename "Size" to "Width" - Set better accelerators REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10859?vs=58946&id=58965 BRANCH fix-annot-config-dialog REVISION DETAIL https://p

D10859: Improve layout of annotation configuration dialogs

simgunz marked 7 inline comments as done. simgunz added inline comments. INLINE COMMENTS > davidhurka wrote in dlgannotationsbase.ui:71 > I think this could be: > **Note:** The information here is used only for annotations. > Information inserted here will be saved in your documents, but will not

D10859: Improve layout of annotation configuration dialogs

ngraham added inline comments. INLINE COMMENTS > simgunz wrote in annotationwidgets.cpp:379 > Sometimes works. :-) Try with a path to an icon. In any case I'll improve the > Stamp tool soon, adding a 'select file' button. I have some code ready that > I'll share soon. Once you do that, it will

D10859: Improve layout of annotation configuration dialogs

simgunz marked 3 inline comments as done. simgunz added a comment. Yes I meant the brushes (that behave as the freehand annotation). For me setting it to Width is fine. INLINE COMMENTS > ngraham wrote in dlgannotationsbase.ui:55 > Is this change intentional? If so, can we just move the amper

D10859: Improve layout of annotation configuration dialogs

davidhurka added a comment. In D10859#472473 , @simgunz wrote: > Not only straight line, but also freehand line, geometrical shape and polygon (with the same meaning). I agree with you, but on the other hand in drawing software like Krita or Gim

D10859: Improve layout of annotation configuration dialogs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks and behaves well to me from a UI perspective! Very nice work. INLINE COMMENTS > dlgannotationsbase.ui:55 > > - &Author: > + Author: > Is this ch

D10859: Improve layout of annotation configuration dialogs

ngraham retitled this revision from "Improve layout of annotation configuraton dialogs" to "Improve layout of annotation configuration dialogs". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: davidhurka, aacid, okular-devel,