Re: [Okular-devel] md5 hash for annotation file name

2008-09-19 Thread Pino Toscano
Alle giovedì 11 settembre 2008, Markus Grabner ha scritto: > The current implementation has the same problem (unless the size of the > file is the same after a modification), but anyway I understood the > annotation concept in okular to be designed for static files. Keeping track > of modifications

Re: [Okular-devel] md5 hash for annotation file name

2008-09-19 Thread Pino Toscano
Alle giovedì 18 settembre 2008, Albert Astals Cid ha scritto: > > Reading the whole document by chunks or once at a single shot is > > basically the same. > > Not really, reading the document as a whole gives you a QByteArray of the > full size of the file, if you read 1MB at a time, you have much

Re: [Okular-devel] md5 hash for annotation file name

2008-09-18 Thread Albert Astals Cid
A Dijous 18 Setembre 2008, Pino Toscano va escriure: > Alle giovedì 11 settembre 2008, Markus Grabner ha scritto: > > Loading the file from a local hard disk takes considerably longer, > > You are assuming whatever will load a document, will load it at once, while > there are file formats that can

Re: [Okular-devel] md5 hash for annotation file name

2008-09-18 Thread Pino Toscano
Alle giovedì 11 settembre 2008, Markus Grabner ha scritto: > Loading the file from a local hard disk takes considerably longer, You are assuming whatever will load a document, will load it at once, while there are file formats that can be read by chunk (eg TIFF, PostScript). > so I'm > not very

Re: [Okular-devel] md5 hash for annotation file name

2008-09-11 Thread Markus Grabner
Am Donnerstag, 11. September 2008 schrieb Brad Hards: > On Thursday 11 September 2008 08:16:05 am Albert Astals Cid wrote: > > A Dijous 11 Setembre 2008, Markus Grabner va escriure: > > > I like Ivo's proposal to use QCryptographicHash, which supports MD4, > > > MD5, and Sha1, so these are natural

Re: [Okular-devel] md5 hash for annotation file name

2008-09-11 Thread Brad Hards
On Thursday 11 September 2008 08:16:05 am Albert Astals Cid wrote: > A Dijous 11 Setembre 2008, Markus Grabner va escriure: > > I like Ivo's proposal to use QCryptographicHash, which supports MD4, MD5, > > and Sha1, so these are natural candidates. > > It's not an attacker, it's you having two file

Re: [Okular-devel] md5 hash for annotation file name

2008-09-10 Thread Markus Grabner
Am Donnerstag, 11. September 2008 schrieb Albert Astals Cid: > A Dijous 11 Setembre 2008, Markus Grabner va escriure: > > I don't see any serious security threat by using a weak hash function at > > this point. All an attacker could do would be to create a modified file > > for which the same annot

Re: [Okular-devel] md5 hash for annotation file name

2008-09-10 Thread Albert Astals Cid
A Dijous 11 Setembre 2008, Markus Grabner va escriure: > Am Mittwoch, 10. September 2008 schrieb Albert Astals Cid: > > A Dimecres 10 Setembre 2008, Markus Grabner va escriure: > > > Hi! > > > > > > It has been discussed (http://bugs.kde.org/show_bug.cgi?id=151614) > > > to use a hash functio

Re: [Okular-devel] md5 hash for annotation file name

2008-09-10 Thread Markus Grabner
Am Mittwoch, 10. September 2008 schrieb Albert Astals Cid: > A Dimecres 10 Setembre 2008, Markus Grabner va escriure: > > Hi! > > > > It has been discussed (http://bugs.kde.org/show_bug.cgi?id=151614) to > > use a hash function to determine the name of the annotation file created > > by oku

Re: [Okular-devel] md5 hash for annotation file name

2008-09-10 Thread Albert Astals Cid
A Dimecres 10 Setembre 2008, Markus Grabner va escriure: > Hi! > > It has been discussed (http://bugs.kde.org/show_bug.cgi?id=151614) to > use a hash function to determine the name of the annotation file created by > okular. The attached patch implements this behaviour (thanks Ivo for > p

[Okular-devel] md5 hash for annotation file name

2008-09-10 Thread Markus Grabner
Hi! It has been discussed (http://bugs.kde.org/show_bug.cgi?id=151614) to use a hash function to determine the name of the annotation file created by okular. The attached patch implements this behaviour (thanks Ivo for pointing me to QCryptographicHash - I looked for such a thing b