Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-08-03 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/ --- (Updated Aug. 3, 2016, 2:02 p.m.) Status -- This change has been mar

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-31 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/#review97956 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark O

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-24 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/ --- (Updated July 24, 2016, 8:04 p.m.) Review request for Okular, Albert Asta

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-24 Thread Martin Tobias Holmedahl Sandsmark
> On July 24, 2016, 2:18 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > core/document.cpp, line 4018 > > > > > > instead use something like: > > if (url.scheme() == "http" && url.host().isEmpty() &&

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-24 Thread Olivier Churlaud
> On July 24, 2016, 4:18 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > core/document.cpp, line 4025 > > > > > > why create a new QUrl? It was like this in master. > On July 24, 2016, 4:18 p.m., Martin To

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-24 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/#review97800 --- core/document.cpp (line 4018)

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-23 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/ --- (Updated July 23, 2016, 1:24 p.m.) Review request for Okular, Albert Asta

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-22 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/#review97771 --- core/document.cpp (line 4003)

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-22 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/#review97764 --- core/document.cpp (line 4017)

[Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-22 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/ --- Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl S