Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128436/ --- (Updated July 14, 2016, 1:17 a.m.) Status -- This change has been di

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Albert Astals Cid
> On July 13, 2016, 2:04 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > did you run the tests (especially the mainshelltest, which has tests for > > the "unique" behaviour? > > Martin Tobias Holmedahl Sandsmark wrote: > but fwiw, your description of the behaviour seems correct to me, bu

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128436/ --- (Updated July 13, 2016, 9:06 p.m.) Review request for Okular, Albert Asta

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Martin Tobias Holmedahl Sandsmark
> On July 13, 2016, 2:04 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > did you run the tests (especially the mainshelltest, which has tests for > > the "unique" behaviour? but fwiw, your description of the behaviour seems correct to me, but I think it should be up to Albert to decide what

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128436/#review97351 --- did you run the tests (especially the mainshelltest, which ha

[Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128436/ --- Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl S