Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-04 Thread Alex Merry
> On Nov. 2, 2015, 9:52 p.m., Albert Astals Cid wrote: > > I'd prefer to know who decides to set a tab of -1 since this doesn't seem > > to be needed in the non frameworks branch seems like the code is "breaking" > > somewhere else > > David Rosca wrote: > QTabWidget::currentChanged probab

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-04 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125890/ --- (Updated Nov. 4, 2015, 11:18 a.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125890/#review87976 --- Ship it! Ship It! - Albert Astals Cid On nov. 3, 2015, 10:

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125890/ --- (Updated Nov. 3, 2015, 10:33 p.m.) Review request for Okular. Repositor

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125890/ --- (Updated Nov. 3, 2015, 10:33 p.m.) Review request for Okular. Repositor

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-03 Thread Albert Astals Cid
> On nov. 2, 2015, 9:52 p.m., Albert Astals Cid wrote: > > I'd prefer to know who decides to set a tab of -1 since this doesn't seem > > to be needed in the non frameworks branch seems like the code is "breaking" > > somewhere else > > David Rosca wrote: > QTabWidget::currentChanged probab

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-03 Thread Albert Astals Cid
> On nov. 2, 2015, 9:52 p.m., Albert Astals Cid wrote: > > I'd prefer to know who decides to set a tab of -1 since this doesn't seem > > to be needed in the non frameworks branch seems like the code is "breaking" > > somewhere else > > David Rosca wrote: > QTabWidget::currentChanged probab

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-02 Thread David Rosca
> On Nov. 2, 2015, 9:52 p.m., Albert Astals Cid wrote: > > I'd prefer to know who decides to set a tab of -1 since this doesn't seem > > to be needed in the non frameworks branch seems like the code is "breaking" > > somewhere else QTabWidget::currentChanged probably because the tab widget (KP

Re: [Okular-devel] Review Request 125890: Fix crash on close

2015-11-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125890/#review87890 --- I'd prefer to know who decides to set a tab of -1 since this d

[Okular-devel] Review Request 125890: Fix crash on close

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125890/ --- Review request for Okular. Repository: okular Description --- Don'