Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-30 Thread Jonathan Doman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118685/ --- (Updated July 30, 2014, 10:15 p.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Jonathan Doman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118685/ --- (Updated July 15, 2014, 9:52 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Jonathan Doman
> On July 15, 2014, 2:27 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 114 > > > > > > What do you mean KTabWidget does not expose the underlying tabbar? > > KTabWidget is a QTabWidget and is setting

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Albert Astals Cid
> On jul. 15, 2014, 7:27 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 114 > > > > > > What do you mean KTabWidget does not expose the underlying tabbar? > > KTabWidget is a QTabWidget and is setting

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Jonathan Doman
> On July 15, 2014, 2:27 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 114 > > > > > > What do you mean KTabWidget does not expose the underlying tabbar? > > KTabWidget is a QTabWidget and is setting

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118685/#review62426 --- shell/shell.cpp

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-14 Thread Jonathan Doman
> On July 14, 2014, 5:45 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 114 > > > > > > Please just call tabBar() If only it were so easy - KTabWidget does not expose the underlying tab bar. Personall

Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-07-14 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118685/#review62354 --- shell/shell.cpp

[Okular-devel] Review Request 118685: Make tabs rearrangeable

2014-06-11 Thread Jonathan Doman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118685/ --- Review request for Okular. Bugs: 334018 http://bugs.kde.org/show_bug.