Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Jan. 13, 2014, 12:40 a.m., Albert Astals Cid wrote: > > I did some small changes on my own so we did not have to go back and forth > > more which would have just made it slow for all. > > Thanks for the patch :-) > > Eugene Shalygin wrote: > Thanks! Very happy that Okular now shows PDF

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Jan. 13, 2014, 1:40 a.m., Albert Astals Cid wrote: > > I did some small changes on my own so we did not have to go back and forth > > more which would have just made it slow for all. > > Thanks for the patch :-) Thanks! Very happy that Okular now shows PDF in correct scale! - Eugene --

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111829/#review47283 --- I did some small changes on my own so we did not have to go ba

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111829/#review47282 --- This review has been submitted with commit ed3559462759bf9b94

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111829/ --- (Updated Jan. 13, 2014, 12:39 a.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 9:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 11:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 9:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 11:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 11:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 9:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 11:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 9:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Oct. 1, 2013, 11:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? The changes were accepted int

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review41080 --- core/utils.cpp

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 25, 2013, 6:13 p.m., Albert Astals Cid wrote: > > Ok, the code looks "sane" but there are two things that still make me > > unsure about this whole thing: > > > > * Why you need Pixels? > > In the bug you say "Points, but actually it is pixels, DIVIDED by 72." > > That is not tru

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 25, 2013, 4:13 p.m., Albert Astals Cid wrote: > > Ok, the code looks "sane" but there are two things that still make me > > unsure about this whole thing: > > > > * Why you need Pixels? > > In the bug you say "Points, but actually it is pixels, DIVIDED by 72." > > That is not tru

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 25, 2013, 6:13 p.m., Albert Astals Cid wrote: > > Ok, the code looks "sane" but there are two things that still make me > > unsure about this whole thing: > > > > * Why you need Pixels? > > In the bug you say "Points, but actually it is pixels, DIVIDED by 72." > > That is not tru

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 25, 2013, 4:13 p.m., Albert Astals Cid wrote: > > Ok, the code looks "sane" but there are two things that still make me > > unsure about this whole thing: > > > > * Why you need Pixels? > > In the bug you say "Points, but actually it is pixels, DIVIDED by 72." > > That is not tru

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 25, 2013, 6:13 p.m., Albert Astals Cid wrote: > > Ok, the code looks "sane" but there are two things that still make me > > unsure about this whole thing: > > > > * Why you need Pixels? > > In the bug you say "Points, but actually it is pixels, DIVIDED by 72." > > That is not tru

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review38556 --- Ok, the code looks "sane" but there are two things that still m

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 21, 2013, 12:57 a.m., Albert Astals Cid wrote: > > core/document_p.h, line 278 > > > > > > Do we need this one? Thanks! This is a leftover from time when Generator was not having dpi() function - Eug

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 21, 2013, 2:56 a.m.) Review request for Okular and Albert As

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review38246 --- core/document_p.h

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 17, 2013, 8:29 p.m.) Review request for Okular and Albert As

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review38036 --- Yeah, i'd drop the multiplication probably. After that i'll giv

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 17, 2013, 2:02 a.m.) Review request for Okular and Albert As

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote: > > > > Eugene Shalygin wrote: > Thanks for the review! I've tried to fix the issues. The only one left is > question with Generator::DPI. I've replaced it with QSizeF (not the best > choice, I know). Somehow keeping both X and Y dpis

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 15, 2013, 11:03 p.m., Albert Astals Cid wrote: > > > > Eugene Shalygin wrote: > Thanks for the review! I've tried to fix the issues. The only one left is > question with Generator::DPI. I've replaced it with QSizeF (not the best > choice, I know). Somehow keeping both X and Y dpi

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote: > > > > Eugene Shalygin wrote: > Thanks for the review! I've tried to fix the issues. The only one left is > question with Generator::DPI. I've replaced it with QSizeF (not the best > choice, I know). Somehow keeping both X and Y dpis

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review37905 --- Agreed with you, a QSizeF is not good either, why you don't wan

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 15, 2013, 11:03 p.m., Albert Astals Cid wrote: > > Thanks for the review! I've tried to fix the issues. The only one left is question with Generator::DPI. I've replaced it with QSizeF (not the best choice, I know). Somehow keeping both X and Y dpis together makes me happy :) Is it go

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 16, 2013, 12:46 a.m.) Review request for Okular and Albert A

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 15, 2013, 11:03 p.m., Albert Astals Cid wrote: > > core/generator.h, line 214 > > > > > > Do we really need this class? I think I'd do with just > > > > setDPI(qreal dpiX, qreal dpiY) > > >

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review37877 --- CMakeLists.txt

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote: > > generators/poppler/generator_pdf.cpp, line 683 > > > > > > Don't use this-> makes me unhappy to see it in C++ code :D Forgot to add: Do we really need

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 2, 2013, 2:19 p.m.) Review request for Okular and Albert Ast

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 1, 2013, 9:11 p.m.) Review request for Okular and Albert Ast

[Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- Review request for Okular and Albert Astals Cid. Description --- This