Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-03 Thread Albert Astals Cid
> On June 3, 2013, 8:50 p.m., Albert Astals Cid wrote: > > So it has been commited :-) Awesome :-) > > > > Jon it'd be great if you could find some time to do some tests similar to > > the ones you did for undo/redo of annotations. > > Jon Mease wrote: > Thanks a lot Albert! :-) > Yes,

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-03 Thread Jon Mease
> On June 3, 2013, 8:50 p.m., Albert Astals Cid wrote: > > So it has been commited :-) Awesome :-) > > > > Jon it'd be great if you could find some time to do some tests similar to > > the ones you did for undo/redo of annotations. Thanks a lot Albert! :-) Yes, I was planning on creating tests

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/#review33700 --- So it has been commited :-) Awesome :-) Jon it'd be great if y

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/#review33698 --- This review has been submitted with commit b7ce9114c56a08770cc

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/ --- (Updated June 3, 2013, 8:47 p.m.) Status -- This change has been mark

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-02 Thread Jon Mease
> On June 1, 2013, 3:40 p.m., Albert Astals Cid wrote: > > Looks good for me besides one small thing, in editFormList and > > editFormCombo you are passing the "old" values while in editFormText and > > editFormButtons you are not (you get them from the forms themselves) is it > > possible not

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-02 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/ --- (Updated June 3, 2013, 1:28 a.m.) Review request for Okular. Changes ---

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-02 Thread Albert Astals Cid
> On June 1, 2013, 3:40 p.m., Albert Astals Cid wrote: > > Looks good for me besides one small thing, in editFormList and > > editFormCombo you are passing the "old" values while in editFormText and > > editFormButtons you are not (you get them from the forms themselves) is it > > possible not

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-01 Thread Jon Mease
> On June 1, 2013, 3:40 p.m., Albert Astals Cid wrote: > > Looks good for me besides one small thing, in editFormList and > > editFormCombo you are passing the "old" values while in editFormText and > > editFormButtons you are not (you get them from the forms themselves) is it > > possible not

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-01 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/#review33561 --- Looks good for me besides one small thing, in editFormList and

Re: [Okular-devel] Review Request 110589: Undo support for PDF forms

2013-06-01 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/#review33557 --- About the view shitfting and outdping out of the viewport, i wo

[Okular-devel] Review Request 110589: Undo support for PDF forms

2013-05-21 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/ --- Review request for Okular. Description --- Add undo / redo support fo