Re: [Okular-devel] Review Request 110480: Fix for removing setInplaceText() in r110391 (compilation fails)

2013-05-18 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110480/ --- (Updated May 18, 2013, 11:52 a.m.) Status -- This change has been dis

Re: [Okular-devel] Review Request 110480: Fix for removing setInplaceText() in r110391 (compilation fails)

2013-05-18 Thread Azat Khuzhin
> On May 18, 2013, 11:47 a.m., Fabio D'Urso wrote: > > Hi, thank you for noticing, however this patch looks wrong to me: it's > > assigning txtann's contents variable to itself. > > > > I remember why I added this special case, because Poppler < 0.20 sometimes > > stored garbage in the DOM nod

Re: [Okular-devel] Review Request 110480: Fix for removing setInplaceText() in r110391 (compilation fails)

2013-05-18 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110480/#review32720 --- Hi, thank you for noticing, however this patch looks wrong to m

Re: [Okular-devel] Review Request 110480: Fix for removing setInplaceText() in r110391 (compilation fails)

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110480/ --- (Updated May 17, 2013, 12:13 a.m.) Review request for Okular and Albert As

[Okular-devel] Review Request 110480: Fix for removing setInplaceText() in r110391

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110480/ --- Review request for Okular and Albert Astals Cid. Description --- Seem