Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104159/#review11320 --- This review has been submitted with commit 486df962030fda0329a

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104159/#review11272 --- Ship it! Ship It! - Albert Astals Cid On March 10, 2012, 11

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-10 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104159/ --- (Updated March 10, 2012, 11:37 a.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-10 Thread Tobias Koenig
> On March 8, 2012, 7:17 p.m., Albert Astals Cid wrote: > > What's the rationale of the setActive bit? Can we just shown/hide the > > videowidget? I wasn't sure if there are other calls to show()/hide() that might interfere with it, therefor I decoupled it. I can recheck the code and change ev

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104159/#review11242 --- What's the rationale of the setActive bit? Can we just shown/hi

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-08 Thread Tobias Koenig
> On March 5, 2012, 10:34 p.m., Albert Astals Cid wrote: > > I don't think i like this much. > > * Who is painting that 'first frame' image? What if there is none? > > * It seems to me that show(); setActive(false); setActive(true); will > > result in stuff still not being shown, doesn't look

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-07 Thread Albert Astals Cid
> On March 5, 2012, 10:34 p.m., Albert Astals Cid wrote: > > I don't think i like this much. > > * Who is painting that 'first frame' image? What if there is none? > > * It seems to me that show(); setActive(false); setActive(true); will > > result in stuff still not being shown, doesn't look

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-07 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104159/ --- (Updated March 7, 2012, 3:07 p.m.) Review request for Okular and Albert As

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-07 Thread Tobias Koenig
> On March 5, 2012, 10:34 p.m., Albert Astals Cid wrote: > > I don't think i like this much. > > * Who is painting that 'first frame' image? What if there is none? > > * It seems to me that show(); setActive(false); setActive(true); will > > result in stuff still not being shown, doesn't look

Re: [Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104159/#review11163 --- I don't think i like this much. * Who is painting that 'first

[Okular-devel] Review Request: Improve activation of video playback in Okular

2012-03-05 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104159/ --- Review request for Okular and Albert Astals Cid. Description --- The