Re: [Okular-devel] Review Request: Comicbook: Open 7z archives with The Unarchiver

2012-10-10 Thread Albert Astals Cid
> On Sept. 8, 2012, 1:49 p.m., Albert Astals Cid wrote: > > David are you there? No answer in a month, closing, please create a new one if you have time again - Albert --- This is an automatically generated e-mail. To reply, visit: http

Re: [Okular-devel] Review Request: Comicbook: Open 7z archives with The Unarchiver

2012-09-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103942/#review18688 --- David are you there? - Albert Astals Cid On Feb. 12, 2012, 4

Re: [Okular-devel] Review Request: Comicbook: Open 7z archives with The Unarchiver

2012-03-04 Thread Albert Astals Cid
> On Feb. 12, 2012, 9:58 p.m., Albert Astals Cid wrote: > > Seems like lots of code of the unar.cpp is "copied" from unrar.cpp could > > you just generalize/share it? Having "duplicate" code is not good. > > David Palacio wrote: > Right, my fault. My original intention is to remove the Rar

Re: [Okular-devel] Review Request: Comicbook: Open 7z archives with The Unarchiver

2012-03-02 Thread David Palacio
> On Feb. 12, 2012, 9:58 p.m., Albert Astals Cid wrote: > > Seems like lots of code of the unar.cpp is "copied" from unrar.cpp could > > you just generalize/share it? Having "duplicate" code is not good. Right, my fault. My original intention is to remove the Rar classes and use only the Unarc

Re: [Okular-devel] Review Request: Comicbook: Open 7z archives with The Unarchiver

2012-02-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103942/#review10567 --- Seems like lots of code of the unar.cpp is "copied" from unrar.

Re: [Okular-devel] Review Request: Comicbook: Open 7z archives with The Unarchiver

2012-02-12 Thread David Palacio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103942/ --- (Updated Feb. 12, 2012, 4:09 p.m.) Review request for Okular. Changes --