Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/#review11759 --- Ship it! Looks good, please commit. - Albert Astals Cid On

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-21 Thread Guillermo Antonio Amaral Bastidas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/ --- (Updated March 22, 2012, 12:18 a.m.) Review request for Okular. Descript

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/#review11726 --- core/movie.cpp

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-21 Thread Guillermo Antonio Amaral Bastidas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/ --- (Updated March 21, 2012, 10:56 p.m.) Review request for Okular. Descript

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/#review11722 --- Can we have a file to test with? cmake/modules/FindPoppler.cm

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-20 Thread Guillermo Antonio Amaral Bastidas
> On March 20, 2012, 11:24 p.m., Albert Astals Cid wrote: > > core/movie.h, line 48 > > > > > > Should fileName have a different name? I mean it's not really a > > fileName is it? It does show up as the original fi

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-20 Thread Guillermo Antonio Amaral Bastidas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/ --- (Updated March 20, 2012, 11:35 p.m.) Review request for Okular. Descript

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-20 Thread Guillermo Antonio Amaral Bastidas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/#review11676 --- cmake/modules/FindPoppler.cmake

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/#review11671 --- Can we have a file to test with? cmake/modules/FindPoppler.cm

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-20 Thread Guillermo Antonio Amaral Bastidas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/ --- (Updated March 20, 2012, 3:53 p.m.) Review request for Okular. Descripti

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/#review11454 --- core/movie.cpp

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/#review11453 --- Can we have a file you've tested the stuff with? generators/p

Re: [Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-15 Thread Guillermo Antonio Amaral Bastidas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/ --- (Updated March 15, 2012, 8:21 p.m.) Review request for Okular. Descripti

[Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

2012-03-15 Thread Guillermo Antonio Amaral Bastidas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104292/ --- Review request for Okular. Description --- Handles new Screen annotat