Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-31 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated Dec. 31, 2012, 2:30 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review24314 --- core/annotations.cpp

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-30 Thread Jon Mease
> On Dec. 27, 2012, 3:22 p.m., Fabio D'Urso wrote: > > core/document.h, line 408 > > > > > > Wondering if "newProps" is redundant. I mean, isn't newProps always the > > same as annotation->getAnnotationPropertiesDo

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-30 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated Dec. 31, 2012, 3:12 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-27 Thread Jon Mease
On Dec. 27, 2012, 3:22 p.m., Jon Mease wrote: > > Sorry for the long delay, I've started to have a look at this new version. > > Apart from the minor issues I've noted, most code looks good to me. > > > > I'm not fully convinced by AnnotWindow changes, I've tested the code a bit > > and I've f

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-27 Thread Fabio D'Urso
> On Dec. 27, 2012, 3:22 p.m., Fabio D'Urso wrote: > > core/document.cpp, line 2016 > > > > > > We need to check that uc is a TranslateAnnotationCommand too, don't we? > > (see example at > > http://qt-project.or

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-27 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review24050 --- core/annotations.cpp

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-01 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated Dec. 1, 2012, 9:33 p.m.) Review request for Okular. Changes ---

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-11-27 Thread Jon Mease
> On Nov. 28, 2012, 12:04 a.m., Fabio D'Urso wrote: > > Hi :) > > > > It seems that the patch doesn't apply any more and needs to be rebased. > > I've tried to reconstruct it and have a quick look, but I couldn't test it > > as it doesn't compile. > > Some comments in random order: > > > > - D

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-11-27 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review22677 --- Hi :) It seems that the patch doesn't apply any more and needs

[Okular-devel] Review Request: Add undo/redo support for annotations

2012-11-23 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- Review request for Okular. Description --- This patch is a first cut