Alle domenica 12 giugno 2011, Christopher Reichert ha scritto:
> > > +m_model = new QFileSystemModel( this );
> >
> > please use a KDirModel
>
> I just want to know why? Maybe KDirModel may be a better KDE api
> option but its not necessarily easy to set up. This would require me
> to reimple
Pino,
Thank you for the time you took to review the code. I think I may have sent
an outdated patch as Albert addressed a few of these issues with me as well.
However, every other point you bring up is valid.
> > +m_model = new QFileSystemModel( this );
>
> please use a KDirModel
>
I just w
Pino,
Thank you for the time you took to review the code. I think I may have sent
an outdated patch as Albert addressed a few of these issues with me as well.
However, every other point you bring up is valid.
> > +m_model = new QFileSystemModel( this );
>
> please use a KDirModel
>
I just w
Hi,
Alle sabato 28 maggio 2011, Christopher Reichert ha scritto:
> +#include
you don't need this
> +m_model = new QFileSystemModel( this );
please use a KDirModel
> +m_docdataDir =
> KStandardDirs().localkdedir().append("share/apps/okular/docdata"); +
this is doubly wrong!
pl
A Saturday, June 04, 2011, Christopher Reichert va escriure:
> ah right, I committed locally but I do not have write access to the okular
> repo so I cannot push the commit.
Well, since it seems you plan sticking around (GREAT!) i think you should ask
for an account. Have a look at
http://techba
ah right, I committed locally but I do not have write access to the okular
repo so I cannot push the commit.
On Sat, Jun 4, 2011 at 2:36 PM, Albert Astals Cid wrote:
> A Saturday, June 04, 2011, Christopher Reichert va escriure:
> > Ok, I have added the branch and commited. Would you like the as
A Saturday, June 04, 2011, Christopher Reichert va escriure:
> Ok, I have added the branch and commited. Would you like the associated
> patch? whats next?
What's the name of the branch? I can not see it when doing git branch -a
Albert
>
> On Sat, Jun 4, 2011 at 11:54 AM, Albert Astals Cid wro
Ok, I have added the branch and commited. Would you like the associated
patch? whats next?
On Sat, Jun 4, 2011 at 11:54 AM, Albert Astals Cid wrote:
> A Saturday, May 28, 2011, Christopher Reichert va escriure:
> > Hey guys,
> > My name is Christopher and I have been working on Okular for a fe
A Saturday, May 28, 2011, Christopher Reichert va escriure:
> Hey guys,
> My name is Christopher and I have been working on Okular for a few
> months. I want to get everyones opinion on a patch that gives a user the
> ability to manage their meta data. This allows users to delete all history
> of
