Re: [Okular-devel] [PATCH] Fix locateFonts

2009-10-27 Thread Albert Astals Cid
A Dimarts, 27 d'octubre de 2009, Igor Stirbu va escriure: > Hello, > > I fixed the issues in the last patch and also removed a bug > in case a font specified in dvi was not found on the system. We've been talking on IRC about it and we've decided to not go ahead, i tought it would be easy at fir

Re: [Okular-devel] [PATCH] Fix locateFonts

2009-10-27 Thread Igor Stirbu
Hello, I fixed the issues in the last patch and also removed a bug in case a font specified in dvi was not found on the system. Thanks, Igor -- :wq Index: fontpool.cpp === --- fontpool.cpp (revision 1041324) +++ fontpool.cpp (worki

Re: [Okular-devel] [PATCH] Fix locateFonts

2009-10-27 Thread Igor Stirbu
Hello, 2009/10/27 Albert Astals Cid : > A Dimarts, 27 d'octubre de 2009, Igor Stirbu va escriure: >  * I know it's not on the file style, but can you please add m_ in front of > the name of member variables you are adding, makes it much easier to track if > they are function or member variables (i

Re: [Okular-devel] [PATCH] Fix locateFonts

2009-10-26 Thread Albert Astals Cid
A Dimarts, 27 d'octubre de 2009, Igor Stirbu va escriure: > Hello, > > I've attached a slightly corrected version for previous patch. Some comments: * I know it's not on the file style, but can you please add m_ in front of the name of member variables you are adding, makes it much easier to tr

Re: [Okular-devel] [PATCH] Fix locateFonts

2009-10-26 Thread Igor Stirbu
Hello, I've attached a slightly corrected version for previous patch. Thanks, Igor -- :wq Index: fontpool.cpp === --- fontpool.cpp (revision 1040770) +++ fontpool.cpp (working copy) @@ -50,6 +50,7 @@ setObjectName("Font Pool"

[Okular-devel] [PATCH] Fix locateFonts

2009-10-26 Thread Igor Stirbu
Hello guys, I've attached a first shot for fixing the issue with processEvents() and replacing by a proper signal/slot implementation. Waiting for comments :) Thanks, Igor -- :wq Index: fontpool.cpp === --- fontpool.cpp (revision 1