D20437: Make selection scrolling go at 60 fps

kezik added a comment. Thanks everybody REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular, aacid, sander, ngraham Cc: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik, joaonetto, tfella, darcyshen

D20437: Make selection scrolling go at 60 fps

kezik added a comment. @aacid ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular, aacid, sander, ngraham Cc: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik, joaonetto, tfella, darcyshen

D20437: Make selection scrolling go at 60 fps

kezik added a comment. @aacid I put myself in the kde dev script relicense thing, so please look at the patch without getting tainted https://phabricator.kde.org/D21070 I'm not sure if I fscked up something in creating that revision, so tell me what to fix, in case. Thanks REP

D20437: Make selection scrolling go at 60 fps

kezik added a comment. In D20437#448397 , @ngraham wrote: > `1000/60` yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value? Being 1000 and 60 integers, an integer division is performed,

D20437: Make selection scrolling go at 60 fps

kezik updated this revision to Diff 56015. kezik added a comment. Even more clear REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20437?vs=55993&id=56015 REVISION DETAIL https://phabricator.kde.org/D20437 AFFECTED FILES ui/pageview.cpp To: kezik, #okul

D20437: Make selection scrolling go at 60 fps

kezik added a comment. Oh, and by the way, the _actual_ speed of the page is set by how far you move the mouse outside the viewport, that constant really doesn't matter, it's only set to a nice value REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #

D20437: Make selection scrolling go at 60 fps

kezik updated this revision to Diff 55993. kezik added a comment. As requested I explain what the "arbitrary constant" does REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20437?vs=55904&id=55993 REVISION DETAIL https://phabricator.kde.org/D20437 AFFECTED

D20437: Make selection scrolling go at 60 fps

kezik added a comment. Well, before my patch the hardcoded constant was "100", (the time between each page update) Now I put an universal constant there (16, as in milliseconds to create a 60fps animation), and moved the hardcoded constant elsewhere I'll update with a comment REPOSITO

D20437: Make selection scrolling go at 60 fps

kezik added a comment. Hi, In D20437#448163 , @sander wrote: > How did you determine the value of the `damping` variable? You write > > With this patch this automatic scrolling goes at 60 fps instead of 10, I made it so that the speed

D20437: Make selection scrolling go at 60 fps

kezik added a comment. It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name @aacid if I put my relicensing preferences on the kde dev script repo, will you consider the patch? Why there is no relicensing agreemen

D20437: Make selection scrolling go at 60 fps

kezik added a comment. F6764690: output.mp4 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular Cc: okular-devel, kezik, joaonetto, tfella, ngraham, darcyshen, aacid

D20437: Make selection scrolling go at 60 fps

kezik created this revision. kezik added a reviewer: Okular. kezik added a project: Okular. Herald added a subscriber: okular-devel. kezik requested review of this revision. REVISION SUMMARY When you select a square with the right mouse button, and you go past the margin of the window (but wher

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. Oh come on I release all my commits as CC0, do what you want, just fix it REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular, ngraham Cc: ngraham, sander, aacid, okular-devel, #okular, joaonetto, tfella, darcyshen

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. In D16519#443979 <https://phabricator.kde.org/D16519#443979>, @ngraham wrote: > I had to do "Kezi Olio" to pass the commit filters which demand a two-part name, hope you don't mind. Perfect Thanks REPOSITORY R223 Okular

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

so we can land this patch with correct authorship information? Thanks! Thanks I don't want to disclose my full name, email is keziolio...@gmail.com and you can put "kezi" as the name REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To:

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. Ping REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular Cc: sander, aacid, okular-devel, #okular, joaonetto, tfella, ngraham, darcyshen

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. Hi, thanks for the feedback. I think uncompressed tablet events are useful for example on krita, when you don't want to lose the "high frequency" content of the drawing on the screen, and latency is not a big issue. I don't see any downsides for okular, mouse eve

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik updated this revision to Diff 54655. kezik retitled this revision from "Don't call scrollTo every time there's a mouseMoveEvent, use a timer instead" to "Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet". kezik edited the summary of this revision. kezi

D16519: Don't call scrollTo every time there's a mouseMoveEvent, use a timer instead

kezik added a comment. hello? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular Cc: okular-devel, #okular, ngraham, aacid

D16519: Don't call scrollTo every time there's a mouseMoveEvent, use a timer instead

kezik updated this revision to Diff 44486. kezik added a comment. Waste less cpu cycles REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16519?vs=44462&id=44486 REVISION DETAIL https://phabricator.kde.org/D16519 AFFECTED FILES ui/pageview.cpp ui/pagevi

D16519: Don't call scrollTo every time there's a mouseMoveEvent, use a timer instead

kezik created this revision. kezik added a reviewer: Okular. kezik added a project: Okular. Herald added a subscriber: okular-devel. kezik requested review of this revision. REVISION SUMMARY BUG: 399208 A workaround to the fact that on some hardware configurations with a wacom tablet (or,