[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

2015-12-28 Thread Yichao Zhou via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #16 from Yichao Zhou --- Hi Dmitry, I tried to reply to this bug this afternoon by email from my smartphone but it seems I did not do it correctly. Sorry for the confusion. The problem about my patch was that the maintainer thought that

[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

2015-12-28 Thread Yichao Zhou via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #14 from Yichao Zhou --- > > https://bugs.kde.org/show_bug.cgi?id=219121 > > Dmitry Osipenko changed: > >What|Removed

[Okular-devel] [okular] [Bug 339005] New: okular will flicker when reloading the document

2014-09-11 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=339005 Bug ID: 339005 Summary: okular will flicker when reloading the document Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severi

Re: [Okular-devel] Review Request 117432: Do not automatically display thumbnail sidebar in startup.

2014-09-08 Thread Yichao Zhou
://git.reviewboard.kde.org/r/117432/diff/ Testing --- Thanks, Yichao Zhou ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-09-08 Thread Yichao Zhou
- conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou ___ Okular-devel mailing list

Re: [Okular-devel] Review Request 115413: Implement smooth wheel scrolling in okular

2014-08-09 Thread Yichao Zhou
pp 65967bf CMakeLists.txt 63d2922 Diff: https://git.reviewboard.kde.org/r/115413/diff/ Testing --- Thanks, Yichao Zhou ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 117432: Do not automatically display thumbnail sidebar in startup.

2014-04-29 Thread Yichao Zhou
> On April 27, 2014, 6:36 p.m., Albert Astals Cid wrote: > > Can you be more precise in the problem you're having? Because if i hide the > > sidebar and open okular with a pdf again the sidebar is properly hidden. > > Yichao Zhou wrote: > 1. Show the sidebar.

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-04-28 Thread Yichao Zhou
d.kde.org/r/115335/#review56802 --- On Feb. 4, 2014, 4:39 a.m., Yichao Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: [Okular-devel] Review Request 117432: Do not automatically display thumbnail sidebar in startup.

2014-04-27 Thread Yichao Zhou
/117432/#review56686 --- On April 9, 2014, 5:28 a.m., Yichao Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: [Okular-devel] Review Request 117432: Do not automatically display thumbnail sidebar in startup.

2014-04-08 Thread Yichao Zhou
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117432/#review55241 --- On April 8, 2014, 9:13 a.m., Yichao Zhou wrote: > > ---

Re: [Okular-devel] Review Request 117432: Do not automatically display thumbnail sidebar in startup.

2014-04-08 Thread Yichao Zhou
/ Testing --- Thanks, Yichao Zhou ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 201108] thumbnail sidebar always gets shown; no way to disable

2014-04-08 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=201108 --- Comment #15 from Yichao Zhou --- It seems that I do not have the permission to reopen a bug. (Or I just cannot find the button to do it). My problem is just like the others: having the thumbnail view always appearing in startup. Here is my

[Okular-devel] Review Request 117432: Do not automatically display thumbnail sidebar in startup.

2014-04-08 Thread Yichao Zhou
/show_bug.cgi?id=201108 Repository: okular Description --- One line patch: Do not automatically display thumbnail sidebar in startup. Diffs - part.cpp 4ce7e28 Diff: https://git.reviewboard.kde.org/r/117432/diff/ Testing --- Thanks, Yichao Zhou

[Okular-devel] [okular] [Bug 201108] thumbnail sidebar always gets shown; no way to disable

2014-04-08 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=201108 Yichao Zhou changed: What|Removed |Added CC||broken.z...@gmail.com --- Comment #13 from

Re: [Okular-devel] Review Request 115413: Implement smooth wheel scrolling in okular

2014-02-09 Thread Yichao Zhou
-- On Jan. 31, 2014, 2:07 p.m., Yichao Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115413/ > ---

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-06 Thread Yichao Zhou
> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 4485 > > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485> > > > > Can you explain why the need for a timer? > > Yichao Zhou wrote: >

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-05 Thread Yichao Zhou
> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 4485 > > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485> > > > > Can you explain why the need for a timer? > > Yichao Zhou wrote: >

[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

2014-02-05 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #12 from Yichao Zhou --- I think it is better to implement this in Okular because evdev emulate this by sending wheel event, which is not as smooth as that implemented in patch. -- You are receiving this mail because: You are the assignee

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-04 Thread Yichao Zhou
> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 4485 > > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485> > > > > Can you explain why the need for a timer? > > Yichao Zhou wrote: >

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-03 Thread Yichao Zhou
zoom, selection, etc.) * In scroll mode, now okular can load new page correctly Diffs (updated) - conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing -

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-03 Thread Yichao Zhou
can load new page correctly Diffs (updated) - conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-03 Thread Yichao Zhou
> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 4485 > > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485> > > > > Can you explain why the need for a timer? > > Yichao Zhou wrote: >

Re: [Okular-devel] Review Request 115413: Implement smooth wheel scrolling in okular

2014-01-31 Thread Yichao Zhou
iff: https://git.reviewboard.kde.org/r/115413/diff/ Testing --- Thanks, Yichao Zhou ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 319870] Add smooth scrolling

2014-01-31 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=319870 Yichao Zhou changed: What|Removed |Added CC||broken.z...@gmail.com --- Comment #6 from Yichao

Re: [Okular-devel] Review Request 115413: Implement smooth wheel scrolling in okular

2014-01-31 Thread Yichao Zhou
Testing --- Thanks, Yichao Zhou ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 115413: Implement smooth wheel scrolling in okular

2014-01-31 Thread Yichao Zhou
rfaces are implemented. Diffs - ui/qsmoothscrollarea.cpp PRE-CREATION ui/qsmoothscrollarea.h PRE-CREATION ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf CMakeLists.txt 63d2922 Diff: https://git.reviewboard.kde.org/r/115413/diff/ Testing --- Thanks, Y

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-31 Thread Yichao Zhou
> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > "* In scroll mode, now okular can load new page correctly" > > > > What does this mean? > > Yichao Zhou wrote: > It means that the orignal patch in Bugs 219121 will not load new p

[Okular-devel] [okular] [Bug 119252] please add smooth scrolling

2014-01-30 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=119252 --- Comment #10 from Yichao Zhou --- Sorry, I misunderstand this request. This is implemented: press next page in okular, the scroll is really smooth. -- You are receiving this mail because: You are the assignee for the bug

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
okular can load new page correctly Diffs (updated) - conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou

[Okular-devel] [okular] [Bug 119252] please add smooth scrolling

2014-01-27 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=119252 Yichao Zhou changed: What|Removed |Added CC||broken.z...@gmail.com --- Comment #9 from Yichao

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
okular can load new page correctly Diffs (updated) - conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
correctly Diffs (updated) - conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
mode, now okular can load new page correctly Diffs (updated) - conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
correctly Diffs (updated) - conf/dlgaccessibilitybase.ui 9e76a75 conf/okular.kcfg deabd07 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/#review48417 ------- On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote: > > --- > This

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
s a bit bad, does update work? repaint is unnecessary. I have fixed that. - Yichao --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/#review48417 ------

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
estVisiblePixmaps(). - Yichao --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/#review48417 --- On Jan. 27, 201

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 2112 > > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line2112> > > > > What's the change in this block? > > Yichao Zhou wrote: > T

[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

2014-01-27 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #10 from Yichao Zhou --- https://git.reviewboard.kde.org/r/115335/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org

[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
deabd07 conf/dlgaccessibilitybase.ui 9e76a75 Diff: https://git.reviewboard.kde.org/r/115335/diff/ Testing --- Thanks, Yichao Zhou ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

2012-01-14 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=219121 Yichao Zhou changed: What|Removed |Added CC||broken.z...@gmail.com --- Comment #4 from