[okular] [Bug 288042] Option to reset forms (PDF)

2025-01-13 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=288042 Noah Davis changed: What|Removed |Added CC||noaha...@gmail.com --- Comment #11 from Noah

T10243: Some KDE applications could use better icons

2020-07-23 Thread Noah Davis
ndavis added a comment. In T10243#236012 , @tosta wrote: > Another icon that need improvement is elisa.svg. It looks bad with dark background. F8757493: elisa-dark-bg-looks-bad.png there was another

T10243: Some KDE applications could use better icons

2020-07-22 Thread Noah Davis
ndavis added a comment. Now that Kate has its own special icon, I don't think Kwrite needs to be changed. TASK DETAIL https://phabricator.kde.org/T10243 To: ndavis Cc: churaev, tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, arrowd, abetts, knauss,

D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype)

2019-11-30 Thread Noah Davis
ndavis added a comment. It took me a while to realize what the feature was, but now that I do, I might prefer to using it. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25628 To: yegori, #vdg, #okular Cc: ndavis, okular-devel, johnzh, andisa, siddharthmanthan, magu

D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype)

2019-11-30 Thread Noah Davis
ndavis added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25628 To: yegori, #vdg, #okular Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566490 , @pino wrote: > In D25484#566482 , @ndavis wrote: > > > In D25484#566477 , @pino wrote: > > > > > > Do people f

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566483 , @romangg wrote: > The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566477 , @pino wrote: > > Do people frequently misclick with the middle mouse button? > > It can happen, and more often with a touchpad. I hadn't considered that. By default, you have to tap with 3 fin

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566470 , @pino wrote: > Please make it configurable, and off by default (otherwise it is too easy to mis-click and close a document). Do people normally misclick with the middle mouse button? Most applic

T10243: Some KDE applications could use better icons

2019-11-02 Thread Noah Davis
ndavis added a comment. In T10243#206631 , @alex-l wrote: > Activities don't add much on Virtual Desktops? It's litterally the only feature for me to use Plasma and don't consider any other DE, the reason I still use X11 despite it's insecure (A

T10243: Some KDE applications could use better icons

2019-11-02 Thread Noah Davis
ndavis added a comment. In T10243#206539 , @alex-l wrote: > Thank you for your replies. As I said I discussed a new icon for Activities time ago but Ivan decided to stay with the 3-dots one. I can't always be around to check that previous decisi

T10243: Some KDE applications could use better icons

2019-11-01 Thread Noah Davis
ndavis added a comment. In T10243#206508 , @alex-l wrote: > To be honest I don't like the new icons. In general Uri with the original Breeze and Ken with its revamped version set original styles with their consistency. They are for me real visua

T10243: Some KDE applications could use better icons

2019-09-19 Thread Noah Davis
ndavis added a comment. In T10243#201445 , @alex-l wrote: > Most common problems for me are: (1) path that is correctly displayed but can't be edited with Inkscape, just moved around Are you talking about some of the mimetype icons? Some

T10243: Some KDE applications could use better icons

2019-09-18 Thread Noah Davis
ndavis added a comment. In T10243#201333 , @ngraham wrote: > In T10243#201329 , @alex-l wrote: > > > EDIT: I have already said this here and there but please don't run any automated script to SVG ico

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-26 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks ready to land! In D22617#502629 , @davidhurka wrote: > - Add missing .ColorScheme-Text { to 24px versions of snap-page.svg > >

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread Noah Davis
ndavis added a comment. In D22617#500953 , @davidhurka wrote: > What does `fill:currentColor` mean, by the way? The current color is determined by the color class. There has to be a `fill`, so we set it to `currentColor`. INLINE COMMENT

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500369 , @davidhurka wrote: > Making the parts with background color transparent would be better, right? That would even work on systems which don’t access the stylesheet. Not necessarily. In Breeze, the

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500346 , @davidhurka wrote: > By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I ca

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500168 , @davidhurka wrote: > Other icons with fold in the bottom I could find: > > - document-duplicate > - document-revert-symbolic[-rtl] > - kt-restore-defaults > - password-copy > - viewpdf > -

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500031 , @davidhurka wrote: > Makes sense, so I’m flipping snap-page now. Is that written down somewhere? Nope, it was recently decided, but I've had that in the back of my mind for a while. > Previ

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread Noah Davis
ndavis added a comment. I'll give the latest changes a proper review in a little while. In D22617#500046 , @davidhurka wrote: > What is the icons-dark directory good for? The icons in there are mostly just the same as in icons. Non-

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Nice work! I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right c

D22259: Reduce default sidebar icon size

2019-07-04 Thread Noah Davis
ndavis added a comment. In D22259#490892 , @stevenv wrote: > In D22259#490551 , @ndavis wrote: > > > I like the idea of having a thinner sidebar, but I don't like the idea of having unlabelled views

D22259: Reduce default sidebar icon size

2019-07-03 Thread Noah Davis
ndavis added a comment. I like the idea of having a thinner sidebar, but I don't like the idea of having unlabeled views by default. I think hiding labels would hurt usability for first time users. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22259 To: stevenv, #

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis added a comment. @aacid `transform-move` is less correct, but it's in Oxygen and Papirus (not Adwaita). Would you prefer if that icon was used? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21630 To: ndavis, #okular, #vdg, ngraham Cc: aacid, ngraham, okular-

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis added a comment. In D21630#475501 , @aacid wrote: > **wow** Not even one minute to review things > > I don't particularly like this, input-mouse is an icon that exists in most icon themes > extra/adwaita-icon-theme > extra/breeze

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

2019-06-06 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH re-arrange-shortcuts-and-menu-items-accordingly (branched from master) REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis Cc: okular-devel, joao

D21633: Change Text Selection icon to edit-select-text

2019-06-06 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R223:2c39981b21d9: Change Text Selection icon to edit-select-text (authored by ndavis). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21633?vs=59284&id=59288 REVISION D

D21633: Change Text Selection icon to edit-select-text

2019-06-06 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R223 Okular BRANCH edit-select-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

2019-06-06 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

2019-06-06 Thread Noah Davis
ndavis added a dependency: D21632: Add edit-select-text, make 16px draw-text like 22px. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

2019-06-06 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

2019-06-06 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. ndavis requested review of this revision. REVISION SUMMARY The current icon (draw-text) is semantically incorrect. This patch makes the Text Selection tool

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R223:9310bed61621: Change Browse icon back to the hand shape (authored by ndavis). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21630?vs=59275&id=59278 REVISION DETAIL

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R223 Okular BRANCH fix-browse-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21630 To: ndavis, #okular, #vdg, ngraham Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21630: Change Browse icon back to the hand shape

2019-06-06 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. ndavis requested review of this revision. REVISION SUMMARY I changed the `input-mouse` icon so that it would look more like a real mouse. In order to keep

D21622: Use a more conventional dropdown menu style instead of press-and-hold

2019-06-06 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH use-more-conventional-dropdown-menu-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D21622 To: ngraham, #okular, #vdg, ndavis Cc: ndavis, abetts, filipf,

D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default

2019-06-06 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH show-text-selection-in-toolbar-menu-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D21624 To: ngraham, #okular, #vdg, ndavis Cc: ndavis, okular-deve

D21622: Use a more conventional dropdown menu style instead of press-and-hold

2019-06-06 Thread Noah Davis
ndavis added a comment. +1, pressing and holding feels unnecessarily slow. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21622 To: ngraham, #okular, #vdg Cc: ndavis, abetts, filipf, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default

2019-06-06 Thread Noah Davis
ndavis added a comment. +1. Text selection is what I want most of the time and having to switch back to it whenever I'm done with the annotation tools is annoying. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21624 To: ngraham, #okular, #vdg Cc: ndavis, okular-dev

D18358: Add buttons to collapse and expand all elements

2019-03-12 Thread Noah Davis
ndavis added a comment. In D18358#429972 , @aacid wrote: > How does it look when you don't have latest breeze? You wouldn't get any icons for "collapse/expand all" buttons without the latest breeze-icons. REPOSITORY R223 Okular REVISI

D15193: Add icons for the Trim Margins tools

2019-01-26 Thread Noah Davis
ndavis added subscribers: trickyricky26, ndavis. ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. The new icons by @trickyricky26 look great! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15193 To: ngraham, #oku

T10243: Some KDE applications could use better icons

2019-01-01 Thread Noah Davis
ndavis added a comment. In T10243#171540 , @aacid wrote: > In T10243#171489 , @ndavis wrote: > > > In T10243#171486 , @aacid wrote: > > > > > Regarding

T10243: Some KDE applications could use better icons

2019-01-01 Thread Noah Davis
ndavis added a comment. Shouldn't our hicolor icons be the same as the icons we use in whatever theme we use as the default? TASK DETAIL https://phabricator.kde.org/T10243 To: ndavis Cc: mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ar

T10243: Some KDE applications could use better icons

2019-01-01 Thread Noah Davis
ndavis added a comment. In T10243#171486 , @aacid wrote: > Regarding Okular, the first is not "Oxygen" icon, it's the Okular icon as we ship it as part of the okular codebase, breeze just decides to overwrite it with a different one. Are

T10243: Some KDE applications could use better icons

2018-12-31 Thread Noah Davis
ndavis added a comment. Kolf and Yakuake just don't look good. Kate and KWrite are too similar. Gwenview and Ark are too plain. KMag isn't clear about what it does. It looks like it's meant to search for something. Okteta isn't clear about what it does either, but it looks nice. KOrg