Re: Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2017-10-11 Thread Jake Linder
ht or right to left (begin/end selection works out no matter in what order user provides them) Thanks, Jake Linder

[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.

2015-10-04 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #10 from Jake Linder --- Gentle reminder, Albert. I've been using a patched version daily for over a month now with no issues. Of course, there may be bugs, but If so they're probably subtle and will surface only when more users

[Okular-devel] [okular] [Bug 186531] [JJ] Trim Margin doesn't work if paper color was set

2015-10-03 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=186531 Jake Linder changed: What|Removed |Added CC||jakelin...@mail.com --- Comment #16 from Jake

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-09-14 Thread Jake Linder
left (begin/end selection works out no matter in what order user provides them) Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-09-14 Thread Jake Linder
g it without issues since posted. - Jake --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/#review85406 --- On Aug. 28, 2015, 7:05

Re: [Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode

2015-09-14 Thread Jake Linder
of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks

[Okular-devel] [okular] [Bug 351889] Switching viewmode/Rotating view can result in low-res page render

2015-09-01 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=351889 --- Comment #3 from Jake Linder --- Updated title and review, same problem occurs when rotating view and rotating back -- You are receiving this mail because: You are the assignee for the bug. ___ Okular

[Okular-devel] [okular] [Bug 351889] Switching viewmode/Rotating view can result in low-res page render

2015-09-01 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=351889 Jake Linder changed: What|Removed |Added Summary|Switching to facing-pages |Switching viewmode/Rotating

Re: [Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode

2015-09-01 Thread Jake Linder
dimensions but is actually a scaled-up version of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks

Re: [Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode

2015-09-01 Thread Jake Linder
dding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/m

[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.

2015-08-29 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #9 from Jake Linder --- Well, how does review board handle history rewrites? I assumed it wouldn't like it. -- You are receiving this mail because: You are the assignee for the bug. ___ O

Re: [Okular-devel] Review Request 124965: Remove help message ref to missing 'Show Forms' menu item

2015-08-28 Thread Jake Linder
Testing --- Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124965: Remove help message ref to missing 'Show Forms' menu item

2015-08-28 Thread Jake Linder
034476 Diff: https://git.reviewboard.kde.org/r/124965/diff/ Testing ------- Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 124965: Remove help message refto missing 'Show Forms' menu item

2015-08-28 Thread Jake Linder
Description --- Remove help message ref to missing 'Show Forms' menu item Diffs - part.cpp d461ebefe9533eefdcf918eb153826479e034476 Diff: https://git.reviewboard.kde.org/r/124965/diff/ Testing --- Thanks, Jake Linder

[Okular-devel] [okular] [Bug 351889] Switching to facing-pages and back to single-page viewmode results in low-res page render

2015-08-28 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=351889 --- Comment #2 from Jake Linder --- Note Bucgtracker Doesn't allow specifying version > 0.22.2 though git is at 0.23.60 -- You are receiving this mail because: You are the assignee for the bug. __

[Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode

2015-08-28 Thread Jake Linder
dimensions but is actually a scaled-up version of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks

[Okular-devel] [okular] [Bug 351889] Switching to facing-pages and back to single-page viewmode results in low-res page render

2015-08-28 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=351889 --- Comment #1 from Jake Linder --- https://git.reviewboard.kde.org/r/124964/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org

[Okular-devel] [okular] [Bug 351889] New: Switching to facing-pages and back to single-page viewmode results in low-res page render

2015-08-28 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=351889 Bug ID: 351889 Summary: Switching to facing-pages and back to single-page viewmode results in low-res page render Product: okular Version: unspecified Platform: Other

[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.

2015-08-28 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #7 from Jake Linder --- Rebased against master: https://git.reviewboard.kde.org/r/124961/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list

[Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-08-28 Thread Jake Linder
erlaps a link, r-click on the link gives the "follow this link" content menu, r-click off link gives the "Copy Text"/etc' context menu - text selection works whe selecting left to right or right to left (begin/end selection work out no matter in

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-27 Thread Jake Linder
an text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink.

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-27 Thread Jake Linder
> On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 494 > > <https://git.reviewboard.kde.org/r/124716/diff/5/?file=397617#file397617line494> > > > > Why this? I think it's the default, no? > > Jake Linder wrote: >

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-27 Thread Jake Linder
view84488 --- On Aug. 27, 2015, 8:10 p.m., Jake Linder wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-27 Thread Jake Linder
marked as submitted. Review request for Okular and Albert Astals Cid. Changes --- Submitted with commit 172d78c6b3f9d7894a1233fb12e5e292f13710ee by Albert Astals Cid on behalf of Jake Linder to branch master. Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-26 Thread Jake Linder
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/#review84427 ------- On Aug. 27, 2015, 6:13 a.m., Jake Linder wrote: > > --- > Thi

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-26 Thread Jake Linder
big and crop down" implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder _

[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.

2015-08-25 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #5 from Jake Linder --- Albert, any thoughts about changing the behavior as suggested? If you're against, it'd be helpful to get your take on the merits of the current behavior because it's probably safe to say that it&

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-23 Thread Jake Linder
mium dimensions size (As percentag of total), as it does in TM mode, because of the "scale big and crop down" implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mo

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-20 Thread Jake Linder
it does in TM mode, because of the "scale big and crop down" implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection int

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-20 Thread Jake Linder
because of the "scale big and crop down" implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks,

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-20 Thread Jake Linder
tion. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-18 Thread Jake Linder
jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 351156] Add "Trim page to selection" feature

2015-08-18 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #14 from Jake Linder --- ping -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-13 Thread Jake Linder
same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-13 Thread Jake Linder
starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-13 Thread Jake Linder
rgins" and desirable configurability for both modes. P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-12 Thread Jake Linder
g selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder __

[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.

2015-08-12 Thread Jake Linder
https://bugs.kde.org/show_bug.cgi?id=318078 Jake Linder changed: What|Removed |Added CC||jakelin...@mail.com --- Comment #4 from Jake

[Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-12 Thread Jake Linder
to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-12 Thread Jake Linder
" and desirable configurability for both modes. P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

2015-08-12 Thread Jake Linder
im Margins" and desirable configurability for both modes. P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel