Re: Reg: the upgrade of the Okular website

Hi, I think a new website for okular.kde.org will help a lot with the promotion of Okular. Making Okular looks like a modern PDF, EPUB, Markdown, (...) reader. But I have some small clarifications: * The Hugo theme will not be created from scratch, since it will reuse the one created for kde.org

T11542: Remove KHTML

ognarb added a revision: D25714: Port away from deprecated KHtml. TASK DETAIL https://phabricator.kde.org/T11542 To: ognarb Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner, cfeck, cullmann,

D22903: Improve search field

ognarb added a comment. See discussion in D18658 , Okular depends on Framework 5.44 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22903 To: jbbgameich, #okular, #plasma:_mobile, ngraham Cc: ognarb, ngraham, okular-devel, maguirre

T10243: Some KDE applications could use better icons

ognarb added a comment. For the Konsole icon, that about putting the current breeze icon into the video-display icon. Something like this: F6925336: test_konsole.png TASK DETAIL https://phabricator.kde.org/T10243 To: ognarb Cc: ognarb, arrowd, a

D19626: Remove find label and use a placeholder text instead

ognarb abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D21281: [RFC] Write Documentation for Okular::Part

ognarb added subscribers: jucato, ognarb. ognarb added a comment. @jucato This could potentially interest you ;) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21281 To: davidhurka, #okular Cc: ognarb, jucato, aacid, okular-devel, joaonetto, tfella, ngraham, darcyshe

D19626: Remove find label and use a placeholder text instead

ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: aacid, ngraham, okular-devel, tfella, darcyshen

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53738. ognarb added a comment. Use string.length > 0 instead of string == "". It's faster REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53338&id=53738 BRANCH arcpatch-D18658 REVISION DETAIL https://phabric

D18658: Modify search bar in the contextDrawer

ognarb added a comment. @aacid It is ready to land now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular, ngraham, aacid Cc: yurchor, ltoscano, aacid, ngraham, okular-devel, tfella, darcyshen

D19626: Remove find label and use instead the placeholder text 'Search...'

ognarb updated this revision to Diff 53485. ognarb added a comment. Use find instead of search REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19626?vs=53483&id=53485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19626 AFFECTED FILES ui/

D19626: Remove find label and use a placeholder text instead

ognarb retitled this revision from "Remove find label and use instead the placeholder text 'Search...'" to "Remove find label and use a placeholder text instead". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: ngraham, okular-devel,

D19626: Remove find label and use instead the placeholder text 'Search...'

ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D19626: Remove find label and use instead the placeholder text 'Search...'

ognarb edited the summary of this revision. ognarb edited the test plan for this revision. ognarb added reviewers: Okular, VDG. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D19626: Remove find label and use instead the placeholder text 'Search...'

ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D19626 AFFECTED FILES ui/findbar.cpp To: ognarb Cc: okular-d

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53338. ognarb marked an inline comment as done. ognarb added a comment. Fix off by on error REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53268&id=53338 BRANCH arcpatch-D18658 REVISION DETAIL https://phabr

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53268. ognarb marked 2 inline comments as done. ognarb added a comment. Change cmake REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53239&id=53268 BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53239. ognarb added a comment. Use a cmake option to build okular with kde framework 5.56 and okular mobile or wit 5.44 and not okular mobile REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53233&id=53239 BRANCH

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 53233. ognarb added a comment. Use text.length > 0 insteaf of text != "" REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=52415&id=53233 BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.kde.org/D186

D18658: Modify search bar in the contextDrawer

ognarb added inline comments. INLINE COMMENTS > aacid wrote in CMakeLists.txt:12 > I don't like this. > > If you need a new kirigami or something make a vesion check and then enable > kirigami only if X verison is available, but i don't like the general > requirement for okular to be increased

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 52415. ognarb added a comment. - Add bottomMargin to search field REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=52407&id=52415 BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.kde.org/D18658 AFF

D18658: Modify search bar in the contextDrawer

ognarb updated this revision to Diff 52407. ognarb edited the summary of this revision. ognarb added a comment. Rebase this diff on latest state of D18716 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=50684&id=

D18658: Modify search bar in the contextDrawer

ognarb added a dependency: D18716: Add a SearchField component. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular, ngraham Cc: ngraham, okular-devel, tfella, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

ognarb added a comment. > The search field shouldn't be touching the line below it; it should have as much padding on top as on bottom. Just needs to be vertically centered in its parent, probably. Ok I will change that :) > Also, instead of manufacturing your own search field, how

D18658: Modify search bar in the contextDrawer

ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY Use a copy of Discover searchBar component, modified. The bigestchange between discover version and this version is that this versio

D18637: Update some files to QQC2 and fix minor bug

This revision was automatically updated to reflect the committed changes. Closed by commit R223:2d568acd7d5f: Update some files to QQC2 and fix minor bug (authored by ognarb). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50678&id=50683 REVISION DETA

D18637: Update some files to QQC2 and fix minor bug

ognarb updated this revision to Diff 50678. ognarb marked an inline comment as done. ognarb added a comment. I mean 1.3 and not 1.2 :) REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50677&id=50678 BRANCH master REVISION DETAIL https://phabrica

D18637: Update some files to QQC2 and fix minor bug

ognarb added a comment. Let's focus with this patch on fixing the depredations and the small bug only. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular, ngraham Cc: ngraham, nicolasfella, okular-devel, tfella, darcyshen, aacid

D18637: Update some files to QQC2 and fix minor bug

ognarb added a comment. So I tried to test ScrollView on my computer with a small display, on it look like it's working. But I prefer to revert this change, and reapply the change concerning ScrollView latter, after testing with my android phone with multitouch support. REPOSITORY R223 Ok

D18637: Update some files to QQC2 and fix minor bug

ognarb updated this revision to Diff 50677. ognarb added a comment. Revert some change REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50630&id=50677 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18637 AFFECTED FILES mobile/app/

D18637: Update some files to QQC2 and fix minor bug

ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18637: Update some files to QQC2 and fix minor bug

ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY The bug was that the Drawer use the `drawerOpen` properties now instead of just `open`. Also fix deprecation Kirigami.Label -> QQC2.L

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

ognarb abandoned this revision. ognarb added a comment. Ok, thanks for the suggestion I will try to look how to create a better dark theme patch when I have time :D REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular, ngraham Cc: davidhurka, ema

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

ognarb added a comment. My use case is that I contently switch between breeze and breeze dark with a script that call `lookandfeeltool` and change Konsole colorscheme. So I wanted that more parts of my system could adapt to this script. I could probably also hack something so that it use the

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY This mode use the QPalette to find a background and foreground color. TEST PLAN Tested manually, all the other render mode still wo

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid