Re: Reg: the upgrade of the Okular website

2019-12-25 Thread Carl Schwan
idea of a new design for the site and that are the requirements (e.g. same urls, not losing any content, not losing the translations) Regards, Carl ‐‐‐ Original Message ‐‐‐ Le mercredi, décembre 25, 2019 7:55 PM, Akshay Nair a écrit : > Hi, > I am interested in revamping the webs

T11542: Remove KHTML

2019-12-03 Thread Carl Schwan
ognarb added a revision: D25714: Port away from deprecated KHtml. TASK DETAIL https://phabricator.kde.org/T11542 To: ognarb Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner, cfeck, cullmann,

[okular] [Bug 412930] Okular does not claim the ability to open .djvu files on Windows even though it can

2019-10-14 Thread carl
https://bugs.kde.org/show_bug.cgi?id=412930 --- Comment #1 from carl --- Created attachment 123178 --> https://bugs.kde.org/attachment.cgi?id=123178&action=edit Open file dialog on Windows -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 412930] New: Okular does not claim the ability to open .djvu files on Windows even though it can

2019-10-14 Thread carl
https://bugs.kde.org/show_bug.cgi?id=412930 Bug ID: 412930 Summary: Okular does not claim the ability to open .djvu files on Windows even though it can Product: okular Version: unspecified Platform: MS Windows

D22903: Improve search field

2019-08-03 Thread Carl Schwan
ognarb added a comment. See discussion in D18658 , Okular depends on Framework 5.44 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22903 To: jbbgameich, #okular, #plasma:_mobile, ngraham Cc: ognarb, ngraham, okular-devel, maguirre

T10243: Some KDE applications could use better icons

2019-06-22 Thread Carl Schwan
ognarb added a comment. For the Konsole icon, that about putting the current breeze icon into the video-display icon. Something like this: F6925336: test_konsole.png TASK DETAIL https://phabricator.kde.org/T10243 To: ognarb Cc: ognarb, arrowd, a

[okular] [Bug 408655] New: vim keys in presentation mode

2019-06-13 Thread carl
https://bugs.kde.org/show_bug.cgi?id=408655 Bug ID: 408655 Summary: vim keys in presentation mode Product: okular Version: 1.7.2 Platform: Other OS: Linux Status: REPORTED Severity: wishlist Prio

D19626: Remove find label and use a placeholder text instead

2019-06-04 Thread Carl Schwan
ognarb abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D21281: [RFC] Write Documentation for Okular::Part

2019-06-02 Thread Carl Schwan
ognarb added subscribers: jucato, ognarb. ognarb added a comment. @jucato This could potentially interest you ;) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21281 To: davidhurka, #okular Cc: ognarb, jucato, aacid, okular-devel, joaonetto, tfella, ngraham, darcyshe

D19626: Remove find label and use a placeholder text instead

2019-03-14 Thread Carl Schwan
ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: aacid, ngraham, okular-devel, tfella, darcyshen

D18658: Modify search bar in the contextDrawer

2019-03-12 Thread Carl Schwan
ognarb updated this revision to Diff 53738. ognarb added a comment. Use string.length > 0 instead of string == "". It's faster REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53338&id=53738 BRANCH arcpatch-D18658 REVISION DETAIL https://phabric

D18658: Modify search bar in the contextDrawer

2019-03-11 Thread Carl Schwan
ognarb added a comment. @aacid It is ready to land now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular, ngraham, aacid Cc: yurchor, ltoscano, aacid, ngraham, okular-devel, tfella, darcyshen

D19626: Remove find label and use instead the placeholder text 'Search...'

2019-03-08 Thread Carl Schwan
ognarb updated this revision to Diff 53485. ognarb added a comment. Use find instead of search REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19626?vs=53483&id=53485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19626 AFFECTED FILES ui/

D19626: Remove find label and use a placeholder text instead

2019-03-08 Thread Carl Schwan
ognarb retitled this revision from "Remove find label and use instead the placeholder text 'Search...'" to "Remove find label and use a placeholder text instead". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: ngraham, okular-devel,

D19626: Remove find label and use instead the placeholder text 'Search...'

2019-03-08 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D19626: Remove find label and use instead the placeholder text 'Search...'

2019-03-08 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb edited the test plan for this revision. ognarb added reviewers: Okular, VDG. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19626 To: ognarb, #okular, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D19626: Remove find label and use instead the placeholder text 'Search...'

2019-03-08 Thread Carl Schwan
ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D19626 AFFECTED FILES ui/findbar.cpp To: ognarb Cc: okular-d

D18658: Modify search bar in the contextDrawer

2019-03-07 Thread Carl Schwan
ognarb updated this revision to Diff 53338. ognarb marked an inline comment as done. ognarb added a comment. Fix off by on error REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53268&id=53338 BRANCH arcpatch-D18658 REVISION DETAIL https://phabr

D18658: Modify search bar in the contextDrawer

2019-03-06 Thread Carl Schwan
ognarb updated this revision to Diff 53268. ognarb marked 2 inline comments as done. ognarb added a comment. Change cmake REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53239&id=53268 BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.

D18658: Modify search bar in the contextDrawer

2019-03-05 Thread Carl Schwan
ognarb updated this revision to Diff 53239. ognarb added a comment. Use a cmake option to build okular with kde framework 5.56 and okular mobile or wit 5.44 and not okular mobile REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=53233&id=53239 BRANCH

D18658: Modify search bar in the contextDrawer

2019-03-05 Thread Carl Schwan
ognarb updated this revision to Diff 53233. ognarb added a comment. Use text.length > 0 insteaf of text != "" REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=52415&id=53233 BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.kde.org/D186

D18658: Modify search bar in the contextDrawer

2019-03-01 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > aacid wrote in CMakeLists.txt:12 > I don't like this. > > If you need a new kirigami or something make a vesion check and then enable > kirigami only if X verison is available, but i don't like the general > requirement for okular to be increased

[okular] [Bug 404792] New: Okular mobile on android doesn't display any icons

2019-02-24 Thread carl
https://bugs.kde.org/show_bug.cgi?id=404792 Bug ID: 404792 Summary: Okular mobile on android doesn't display any icons Product: okular Version: 1.6.2 Platform: Android OS: Android 8.x Status: REPORTED Seve

D18658: Modify search bar in the contextDrawer

2019-02-23 Thread Carl Schwan
ognarb updated this revision to Diff 52415. ognarb added a comment. - Add bottomMargin to search field REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=52407&id=52415 BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.kde.org/D18658 AFF

D18658: Modify search bar in the contextDrawer

2019-02-23 Thread Carl Schwan
ognarb updated this revision to Diff 52407. ognarb edited the summary of this revision. ognarb added a comment. Rebase this diff on latest state of D18716 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18658?vs=50684&id=

D18658: Modify search bar in the contextDrawer

2019-02-03 Thread Carl Schwan
ognarb added a dependency: D18716: Add a SearchField component. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular, ngraham Cc: ngraham, okular-devel, tfella, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

2019-02-03 Thread Carl Schwan
ognarb added a comment. > The search field shouldn't be touching the line below it; it should have as much padding on top as on bottom. Just needs to be vertically centered in its parent, probably. Ok I will change that :) > Also, instead of manufacturing your own search field, how

D18658: Modify search bar in the contextDrawer

2019-02-01 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

2019-02-01 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

2019-02-01 Thread Carl Schwan
ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY Use a copy of Discover searchBar component, modified. The bigestchange between discover version and this version is that this versio

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R223:2d568acd7d5f: Update some files to QQC2 and fix minor bug (authored by ognarb). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50678&id=50683 REVISION DETA

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb updated this revision to Diff 50678. ognarb marked an inline comment as done. ognarb added a comment. I mean 1.3 and not 1.2 :) REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50677&id=50678 BRANCH master REVISION DETAIL https://phabrica

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb added a comment. Let's focus with this patch on fixing the depredations and the small bug only. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular, ngraham Cc: ngraham, nicolasfella, okular-devel, tfella, darcyshen, aacid

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb added a comment. So I tried to test ScrollView on my computer with a small display, on it look like it's working. But I prefer to revert this change, and reapply the change concerning ScrollView latter, after testing with my android phone with multitouch support. REPOSITORY R223 Ok

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb updated this revision to Diff 50677. ognarb added a comment. Revert some change REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50630&id=50677 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18637 AFFECTED FILES mobile/app/

D18637: Update some files to QQC2 and fix minor bug

2019-01-31 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18637: Update some files to QQC2 and fix minor bug

2019-01-31 Thread Carl Schwan
ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY The bug was that the Drawer use the `drawerOpen` properties now instead of just `open`. Also fix deprecation Kirigami.Label -> QQC2.L

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-31 Thread Carl Schwan
ognarb abandoned this revision. ognarb added a comment. Ok, thanks for the suggestion I will try to look how to create a better dark theme patch when I have time :D REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular, ngraham Cc: davidhurka, ema

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-31 Thread Carl Schwan
ognarb added a comment. My use case is that I contently switch between breeze and breeze dark with a script that call `lookandfeeltool` and change Konsole colorscheme. So I wanted that more parts of my system could adapt to this script. I could probably also hack something so that it use the

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Carl Schwan
ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY This mode use the QPalette to find a background and foreground color. TEST PLAN Tested manually, all the other render mode still wo

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

2019-01-30 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18623 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

Re: Review Request 127366: Resize annotations

2016-10-09 Thread Carl-Daniel Hailfinger
hould aid keeping consistency and avoiding conflicts in the UI. It also > helps to identify and separate common code. On the other hand there's more to > review for you, and there's higher risk of introducing regressions. > > Are both changes OK for you? If so, I

[okular] [Bug 370382] New: Using non-default size for custom stamp pixelates the stamp

2016-10-09 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370382 Bug ID: 370382 Summary: Using non-default size for custom stamp pixelates the stamp Product: okular Version: unspecified Platform: Compiled Sources OS: Linux

[okular] [Bug 370381] New: Custom stamp has default square dimensions regardless of original graphic

2016-10-09 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370381 Bug ID: 370381 Summary: Custom stamp has default square dimensions regardless of original graphic Product: okular Version: unspecified Platform: Compiled Sources O

[okular] [Bug 370380] New: Please add 0.26.x to okular version list in bug tracker

2016-10-09 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370380 Bug ID: 370380 Summary: Please add 0.26.x to okular version list in bug tracker Product: okular Version: unspecified Platform: Compiled Sources OS: Linux

[okular] [Bug 335045] want to creat an own stamp within annotations

2016-10-09 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=335045 --- Comment #2 from Carl-Daniel Hailfinger --- Please note that as of okular 0.26.70, custom stamps can be saved with the PDF, but other PDF viewers seem to ignore them. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 335045] want to creat an own stamp within annotations

2016-10-09 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=335045 Carl-Daniel Hailfinger changed: What|Removed |Added CC||c-d.hailfinger.devel.2006@g

[okular] [Bug 246196] When filling in forms, make it possible to set the font size of the forms

2016-10-09 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=246196 --- Comment #14 from Carl-Daniel Hailfinger --- Patch for poppler is now in https://bugs.freedesktop.org/show_bug.cgi?id=60836 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 246196] When filling in forms, make it possible to set the font size of the forms

2016-10-09 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=246196 --- Comment #11 from Carl-Daniel Hailfinger --- Which component? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 246196] When filling in forms, make it possible to set the font size of the forms

2016-10-08 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=246196 --- Comment #9 from Carl-Daniel Hailfinger --- Created attachment 101493 --> https://bugs.kde.org/attachment.cgi?id=101493&action=edit Hardcode a reasonable default max font size for form fields if autosize=on This patch solves the im

[okular] [Bug 246196] When filling in forms, make it possible to set the font size of the forms

2016-10-08 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=246196 --- Comment #8 from Carl-Daniel Hailfinger --- Working on this... right now I can set a max font size for forms where the font size is not specified. No GUI, and still requires recompilation of libpoppler if you want a different size. Then again

[okular] [Bug 246196] When filling in forms, make it possible to set the font size of the forms

2016-10-08 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=246196 Carl-Daniel Hailfinger changed: What|Removed |Added CC||c-d.hailfinger.devel.2006@g

[okular] [Bug 363768] Font size is changed when form value is modified

2016-10-06 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363768 Carl-Daniel Hailfinger changed: What|Removed |Added CC||c-d.hailfinger.devel.2006@g

[Okular-devel] [okular] [Bug 351026] okular compilation requires qjson, but does not check for it

2015-08-06 Thread Carl-Daniel Hailfinger
https://bugs.kde.org/show_bug.cgi?id=351026 --- Comment #6 from Carl-Daniel Hailfinger --- $ git show --summary commit 346e7a32eab9c00333794aca590a4a5bb8954bfd Merge: ba28b64 e2b5bc5 Author: Albert Astals Cid Date: Thu Aug 6 00:31:59 2015 +0200 Merge remote-tracking branch 'o

[Okular-devel] [okular] [Bug 351026] okular compilation requires qjson, but does not check for it

2015-08-06 Thread Carl-Daniel Hailfinger
https://bugs.kde.org/show_bug.cgi?id=351026 --- Comment #4 from Carl-Daniel Hailfinger --- build/CMakeFiles/okularcore.dir/link.txt is where qjson gets mentioned. It is attached. -- You are receiving this mail because: You are the assignee for the bug

[Okular-devel] [okular] [Bug 351026] okular compilation requires qjson, but does not check for it

2015-08-06 Thread Carl-Daniel Hailfinger
https://bugs.kde.org/show_bug.cgi?id=351026 --- Comment #3 from Carl-Daniel Hailfinger --- Created attachment 93922 --> https://bugs.kde.org/attachment.cgi?id=93922&action=edit build/CMakeFiles/okularcore.dir/link.txt -- You are receiving this mail because: You are the assignee for

[Okular-devel] [okular] [Bug 351026] okular compilation requires qjson, but does not check for it

2015-08-06 Thread Carl-Daniel Hailfinger
https://bugs.kde.org/show_bug.cgi?id=351026 --- Comment #1 from Carl-Daniel Hailfinger --- This is latest okular from git as of 2015-08-06. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list

[Okular-devel] [okular] [Bug 351026] New: okular compilation requires qjson, but does not check for it

2015-08-06 Thread Carl-Daniel Hailfinger
https://bugs.kde.org/show_bug.cgi?id=351026 Bug ID: 351026 Summary: okular compilation requires qjson, but does not check for it Product: okular Version: unspecified Platform: Compiled Sources OS: Linux

[Okular-devel] [okular] [Bug 334708] Accessing QPrinter to get the page size name is blocking if default printer is not connected

2015-03-19 Thread Norman Carl Freudenberg
https://bugs.kde.org/show_bug.cgi?id=334708 Norman Carl Freudenberg changed: What|Removed |Added CC||ko...@gmx.net -- You are receiving

[Okular-devel] [Bug 177501] undo button or function missing

2012-10-11 Thread Carl
https://bugs.kde.org/show_bug.cgi?id=177501 Carl changed: What|Removed |Added CC|carlvanops...@gmail.com | -- You are receiving this mail because: You are the

[Okular-devel] [Bug 177501] undo button or function missing

2009-09-02 Thread Carl
https://bugs.kde.org/show_bug.cgi?id=177501 Carl changed: What|Removed |Added CC||carlvanops...@gmail.com --- Comment #3 from Carl