/libokularGenerator_comicbook.desktop 5a91a5f
generators/comicbook/okularApplication_comicbook.desktop dee494b
generators/comicbook/okularComicbook.desktop 1dded78
Diff: https://git.reviewboard.kde.org/r/125020/diff/
Testing
---
Build; open some archives in okular.
Thanks,
Boris Egorov
> On Oct. 4, 2015, 10:32 p.m., Albert Astals Cid wrote:
> > This patch does not give me an image for the first page of the linked
> > document. Any idea what may be wrong?
>
> Boris Egorov wrote:
> Do you have warnings like this in terminal?
>
>
>
t should work, but it
> > doesn't tell the rest of the world so dolphin et al won't suggest okular to
> > open random .rar files. I think this should be a good enough compromise,
> > can you check what i am saying is actually true?
>
> Boris Egorov wrote:
>
> On Oct. 4, 2015, 10:32 p.m., Albert Astals Cid wrote:
> > This patch does not give me an image for the first page of the linked
> > document. Any idea what may be wrong?
>
> Boris Egorov wrote:
> Do you have warnings like this in terminal?
>
>
>
> On Oct. 4, 2015, 10:32 p.m., Albert Astals Cid wrote:
> > This patch does not give me an image for the first page of the linked
> > document. Any idea what may be wrong?
>
> Boris Egorov wrote:
> Do you have warnings like this in terminal?
>
>
>
y, visit:
https://git.reviewboard.kde.org/r/125500/#review86356
---
On Oct. 3, 2015, 8:27 a.m., Boris Egorov wrote:
>
> ---
> This is an automatically generated e-mail.
e.org/r/125500/diff/
Testing
---
Open metioned file with patch applied. There is no warnings and images loaded
successfully.
Thanks,
Boris Egorov
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
is actually true?
I'll check it asap.
- Boris
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125020/#review85517
-------
https://bugs.kde.org/show_bug.cgi?id=343645
--- Comment #5 from Boris Egorov ---
I've made a review request with changed .desktop files. rar archives opens too.
Code to handle x-rar/zip mimetypes in comicbook lives in
ComicBook::Document::open().
--
You are receiving this mail because
generators/comicbook/okularComicbook.desktop 1dded78
Diff: https://git.reviewboard.kde.org/r/125020/diff/
Testing
---
Build; open some archives in okular.
Thanks,
Boris Egorov
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org
https://bugs.kde.org/show_bug.cgi?id=343645
--- Comment #4 from Boris Egorov ---
Huh. Actually, it already works. All what needs to be done is to include
application/zip to .desktop files.
--
You are receiving this mail because:
You are the assignee for the bug
https://bugs.kde.org/show_bug.cgi?id=343645
Boris Egorov changed:
What|Removed |Added
CC||ego...@linux.com
--- Comment #1 from Boris
https://bugs.kde.org/show_bug.cgi?id=213508
Boris Egorov changed:
What|Removed |Added
CC||ego...@linux.com
--- Comment #4 from Boris
13 matches
Mail list logo
